Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump odo to v3.0.0-rc2 #6137

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Bump odo to v3.0.0-rc2 #6137

merged 1 commit into from
Sep 20, 2022

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Sep 20, 2022

No description provided.

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit dfc39d8
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6329a478e331da0009d915cd

@feloy
Copy link
Contributor

feloy commented Sep 20, 2022

/approve
/lgtm

@anandrkskd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandrkskd, feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 20, 2022
@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Unit Tests on commit 87a2ef7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Validate Tests on commit 87a2ef7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

OpenShift Tests on commit 87a2ef7 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Kubernetes Tests on commit 87a2ef7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Windows Tests (OCP) on commit 87a2ef7 finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Sep 20, 2022

This PR introduces changes in the Devfiles metadata that break the integration tests:

devfile/registry@30d83f5

@valaparthvi
Copy link
Contributor

This PR introduces changes in the Devfiles metadata that break the integration tests:

devfile/registry@30d83f5

I am not sure I understand why this has failed. Is it because we are using proxy or something else?

@kadel
Copy link
Member

kadel commented Sep 20, 2022

This PR introduces changes in the Devfiles metadata that break the integration tests:
devfile/registry@30d83f5

I am not sure I understand why this has failed. Is it because we are using proxy or something else?

No, it is because of updated metadata.
For example, the language field in Go stacks got capitalized. And our tests are doing strict matching, so they are expecting go on the output, but the updated stack has Go.

@valaparthvi
Copy link
Contributor

#6140

@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

/hold

Blocked on #6140

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 20, 2022
@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

/hold cancel

@dharmit Could you please rebase your branch onto main, now that #6140 is merged?

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 20, 2022
Signed-off-by: Dharmit Shah <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

New changes are detected. LGTM label has been removed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2022
@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

Resource issues in the OpenShift cluster? cc @valaparthvi (as the test boss for this week ;-))
One test was failing because of insufficient resources, but the pod ended up being scheduled but too late for the timeout; I think we can override this.

  Timed out after 180.001s.
  Expected
      <string>:   __
       /  \__     Developing using the nodejs Devfile
       \__/  \    Namespace: cmd-delete-test270uts
       /  \__/    odo version: v3.0.0-rc2
       \__/
      
      ↪ Deploying to the cluster in developer mode
       •  Waiting for Kubernetes resources  ...
       ⚠  Pod is Pending
       ⚠  0/3 nodes are available: 3 Insufficient memory.
       ⚠  0/3 nodes are available: 3 Insufficient memory.
       ⚠  0/3 nodes are available: 3 Insufficient memory.
       ✓  Pod is Running
       •  Syncing files into the container  ...

...
Summarizing 1 Failure:
  [FAIL] odo delete command tests when deleting a component containing preStop event that is deployed with DEV [BeforeEach] should contain preStop events list
  /go/odo_1/tests/helper/helper_run.go:40

@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

/override OpenShift-Integration-tests/OpenShift-Integration-tests

And on Windows (which seems unstable), we had:

[odo] I0920 07:18:49.600969    4932 delete.go:75] failed to delete resource "vbymvz-app" (apps.v1.deployments): timeout while waiting for "vbymvz-app" resource to be deleted
+ [FAILED] [0.208 seconds]
odo add binding command tests [BeforeEach]
C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/integration/cmd_add_binding_test.go:18
  should create a binding using the workload parameter
  C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/integration/cmd_add_binding_test.go:42

...
    [oc] Error from server (ServiceUnavailable): the server is currently unable to handle the request
    Setting current dir to: 
  << End Captured GinkgoWriter Output

  No future change is possible.  Bailing out early after 0.200s.
  Running oc.exe with args [oc new-project cmd-add-binding-test42qcv]
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/helper/helper_cmd_wrapper.go:101

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@rm3l: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

And on Windows (which seems unstable), we had:

[odo] I0920 07:18:49.600969    4932 delete.go:75] failed to delete resource "vbymvz-app" (apps.v1.deployments): timeout while waiting for "vbymvz-app" resource to be deleted
+ [FAILED] [0.208 seconds]
odo add binding command tests [BeforeEach]
C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/integration/cmd_add_binding_test.go:18
 should create a binding using the workload parameter
 C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/integration/cmd_add_binding_test.go:42

...
   [oc] Error from server (ServiceUnavailable): the server is currently unable to handle the request
   Setting current dir to: 
 << End Captured GinkgoWriter Output

 No future change is possible.  Bailing out early after 0.200s.
 Running oc.exe with args [oc new-project cmd-add-binding-test42qcv]
 Expected
     <int>: 1
 to match exit code:
     <int>: 0
 In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/2042/tests/helper/helper_cmd_wrapper.go:101

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Sep 20, 2022

• [FAILED] [67.700 seconds]
odo dev command tests
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:31
  when running odo dev and devfile with composite command - with metadata.name
  /go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:1449
    [It] should execute all commands in composite command
    /go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:1468

...

[oc] Error from server (Forbidden): pods is forbidden: User "developer" cannot list resource "pods" in API group "" in the namespace "cmd-dev-test1468hip": RBAC: [clusterrole.rbac.authorization.k8s.io "cluster-status" not found, clusterrole.rbac.authorization.k8s.io "system:basic-user" not found, clusterrole.rbac.authorization.k8s.io "basic-user" not found, clusterrole.rbac.authorization.k8s.io "service-binding-clusterworkloadresourcemappings-viewer-role" not found, clusterrole.rbac.authorization.k8s.io "system:oauth-token-deleter" not found, clusterrole.rbac.authorization.k8s.io "self-access-reviewer" not found, clusterrole.rbac.authorization.k8s.io "system:discovery" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-docker" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:scc:restricted-v2" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-jenkinspipeline" not found, clusterrole.rbac.authorization.k8s.io "system:webhook" not found, clusterrole.rbac.authorization.k8s.io "self-provisioner" not found, clusterrole.rbac.authorization.k8s.io "system:public-info-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:useroauthaccesstoken-manager" not found, clusterrole.rbac.authorization.k8s.io "system:scope-impersonation" not found, clusterrole.rbac.authorization.k8s.io "console-extensions-reader" not found, clusterrole.rbac.authorization.k8s.io "helm-chartrepos-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:public-info-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:discovery" not found, clusterrole.rbac.authorization.k8s.io "service-binding-bindablekinds-viewer-role" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-source" not found]
    [odo] read: read /dev/stdin: input/output error

Same tests passing on IBM Cloud.

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

• [FAILED] [67.700 seconds]
odo dev command tests
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:31
 when running odo dev and devfile with composite command - with metadata.name
 /go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:1449
   [It] should execute all commands in composite command
   /go/src/github.com/redhat-developer/odo/tests/integration/cmd_dev_test.go:1468

...

[oc] Error from server (Forbidden): pods is forbidden: User "developer" cannot list resource "pods" in API group "" in the namespace "cmd-dev-test1468hip": RBAC: [clusterrole.rbac.authorization.k8s.io "cluster-status" not found, clusterrole.rbac.authorization.k8s.io "system:basic-user" not found, clusterrole.rbac.authorization.k8s.io "basic-user" not found, clusterrole.rbac.authorization.k8s.io "service-binding-clusterworkloadresourcemappings-viewer-role" not found, clusterrole.rbac.authorization.k8s.io "system:oauth-token-deleter" not found, clusterrole.rbac.authorization.k8s.io "self-access-reviewer" not found, clusterrole.rbac.authorization.k8s.io "system:discovery" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-docker" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:scc:restricted-v2" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-jenkinspipeline" not found, clusterrole.rbac.authorization.k8s.io "system:webhook" not found, clusterrole.rbac.authorization.k8s.io "self-provisioner" not found, clusterrole.rbac.authorization.k8s.io "system:public-info-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:useroauthaccesstoken-manager" not found, clusterrole.rbac.authorization.k8s.io "system:scope-impersonation" not found, clusterrole.rbac.authorization.k8s.io "console-extensions-reader" not found, clusterrole.rbac.authorization.k8s.io "helm-chartrepos-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:public-info-viewer" not found, clusterrole.rbac.authorization.k8s.io "system:openshift:discovery" not found, clusterrole.rbac.authorization.k8s.io "service-binding-bindablekinds-viewer-role" not found, clusterrole.rbac.authorization.k8s.io "system:build-strategy-source" not found]
   [odo] read: read /dev/stdin: input/output error

Same tests passing on IBM Cloud.

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 39a9a28 into redhat-developer:main Sep 20, 2022
@dharmit dharmit deleted the 3.0.0-rc2 branch September 22, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants