Create document highlighting dev and deploy #6120
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
When reviewing, please add any suggestions you have! |
|
@cdrage: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think this is a good start. It addresses the most frequent confusion that I say. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Currently, the doc does not clarify what environment a user is supposed to work with from the beginning. I think it makes sense to clarify from the beginning that odo dev is supposed to work with a dev environment and odo deploy is supposed to work with a production-like environment. I would prefer talking about them before we list all the potential tasks.
cdrage
force-pushed
the
dev-vs-deploy
branch
from
e74b8e9 to
1fdbe29
Compare
|
Good suggestions! Thanks @valaparthvi and @rm3l I've gone ahead and switched the sentences to be more grammatically correct and in lower case. Thanks! |
openshift-ci
bot
added
the
lgtm
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** * Adds document on how to do dev vs deploy and which command you should use * Highlights when to use either command **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Closes redhat-developer#6083 Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
dev-vs-deploy
branch
from
1fdbe29 to
15b5ffd
Compare
openshift-ci
bot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
I rebased, so re-adding lgtm label |
cdrage
added
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests |
|
@cdrage: Overrode contexts on behalf of cdrage: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Create document highlighting dev and deploy <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** * Adds document on how to do dev vs deploy and which command you should use * Highlights when to use either command **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Closes redhat-developer#6083 Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Update docs/website/docs/overview/dev_and_deploy.md Co-authored-by: Parthvi Vala <pvala@redhat.com> * Update docs/website/docs/overview/dev_and_deploy.md Co-authored-by: Parthvi Vala <pvala@redhat.com> * Update docs/website/docs/overview/dev_and_deploy.md Co-authored-by: Parthvi Vala <pvala@redhat.com> * switch to lowercase sentences Signed-off-by: Charlie Drage <charlie@charliedrage.com> Signed-off-by: Charlie Drage <charlie@charliedrage.com> Co-authored-by: Parthvi Vala <pvala@redhat.com>
Create document highlighting dev and deploy
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
use
Which issue(s) this PR fixes:
Closes #6083
Signed-off-by: Charlie Drage charlie@charliedrage.com