Skip to content

Do not display message when using no-watch flag #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 12, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6103

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b931183
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/631f4f543b4748000852d551

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2022
@feloy feloy requested review from dharmit and rm3l September 12, 2022 14:50
@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Unit Tests on commit c8d628a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Validate Tests on commit c8d628a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Kubernetes Tests on commit c8d628a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

OpenShift Tests on commit c8d628a finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6103/no-watch-no-message branch from c556d49 to b931183 Compare September 12, 2022 15:25
@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Windows Tests (OCP) on commit c8d628a finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 13, 2022
@rm3l rm3l closed this Sep 13, 2022
@rm3l rm3l reopened this Sep 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Sep 13, 2022

[FAILED] [126.513 seconds]
odo add binding interactive command tests
/go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:16
  when running a deployment
  /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:300
    when binding to a service in a different namespace
    /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:551
      [It] should error out if service is not found in the namespace selected
      /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:574

Flaky test

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

[FAILED] [126.513 seconds]
odo add binding interactive command tests
/go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:16
 when running a deployment
 /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:300
   when binding to a service in a different namespace
   /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:551
     [It] should error out if service is not found in the namespace selected
     /go/src/github.com/redhat-developer/odo/tests/integration/interactive_add_binding_test.go:574

Flaky test

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8b5986f into redhat-developer:main Sep 13, 2022
valaparthvi pushed a commit to valaparthvi/odo that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching for changes in the current directory is displayed when no-watch flag is used
3 participants