Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Non odo components not reported #6021

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix: Non odo components not reported #6021

merged 2 commits into from
Aug 17, 2022

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala [email protected]

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This PR fixes the bug where components not managed by odo were not detected by odo.
Which issue(s) this PR fixes:

Fixes #6007

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Create a component from OpenShift Web Console.
  2. Run odo list
  3. See if the component is detected.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 11, 2022
@valaparthvi valaparthvi marked this pull request as ready for review August 11, 2022 09:22
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Aug 11, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit da049ee
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62fc6948bebbdd00086627ce

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Aug 11, 2022
@openshift-ci openshift-ci bot requested review from rm3l and rnapoles-rh August 11, 2022 09:23
@odo-robot
Copy link

odo-robot bot commented Aug 11, 2022 •
edited
Loading

Unit Tests on commit 8ad092b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 11, 2022 •
edited
Loading

Windows Tests (OCP) on commit 8ad092b finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 11, 2022 •
edited
Loading

Validate Tests on commit 8ad092b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 11, 2022 •
edited
Loading

Kubernetes Tests on commit 8ad092b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 11, 2022 •
edited
Loading

OpenShift Tests on commit 8ad092b finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 16, 2022
@valaparthvi
Fix: Non odo components not reported
574ff34 
Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi
Add unit test
da049ee 
Signed-off-by: Parthvi Vala <[email protected]>
@feloy feloy closed this Aug 17, 2022
@feloy feloy reopened this Aug 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@valaparthvi
Copy link
Contributor Author

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor Author

@feloy IBM K8s tests have passed, thanks for the reopening.

@feloy
Copy link
Contributor

feloy commented Aug 17, 2022

Thanks for these changes

/lgtm

/override ci/prow/v4.10-integration-e2e
Infra error; tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

Thanks for these changes

/lgtm

/override ci/prow/v4.10-integration-e2e
Infra error; tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit b4ee872 into redhat-developer:main Aug 17, 2022
feloy added a commit to feloy/odo that referenced this pull request Aug 18, 2022
@feloy
Revert "Fix: Non odo components not reported (redhat-developer#6021)"
43d8e64 
This reverts commit b4ee872.
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @cdrage
Fix: Non odo components not reported (redhat-developer#6021)
639f1db 
* Fix: Non odo components not reported

Signed-off-by: Parthvi Vala <[email protected]>

* Add unit test

Signed-off-by: Parthvi Vala <[email protected]>

Signed-off-by: Parthvi Vala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l left review comments

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non odo components not reported
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot