Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use devfile proxy for odo init --devfile-registry #5995

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Use devfile proxy for odo init --devfile-registry #5995

merged 2 commits into from
Aug 4, 2022
+18 −10

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 1, 2022

What type of PR is this:

/kind tests

What does this PR do / why we need it:

This PR makes all tests use the devfile proxy, including the tests using odo init --devfile-registry

@openshift-ci openshift-ci bot requested review from dharmit and rnapoles-rh August 1, 2022 10:24
@netlify
Copy link

netlify bot commented Aug 1, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit ec8e5c2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62e8f892bff3ab0008fa0fb0
😎 Deploy Preview https://deploy-preview-5995--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2022 •
edited
Loading

Unit Tests on commit 912f3e8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2022 •
edited
Loading

Validate Tests on commit 912f3e8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2022 •
edited
Loading

Windows Tests (OCP) on commit 912f3e8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2022 •
edited
Loading

Kubernetes Tests on commit 912f3e8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2022 •
edited
Loading

OpenShift Tests on commit 912f3e8 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Aug 1, 2022
@kadel
Copy link
Member

kadel commented Aug 1, 2022 •
edited
Loading

Can we please document this somewhere?

Maybe we could merge #5686 even if it is not completed and add this new env variable to the list.
I think that even a list of the env variables that odo uses is still useful, we can add a description later. I'm starting to get worried about all the hidden settings hat we keep adding into odo that are nowhere documented

@feloy
Copy link
Contributor Author

feloy commented Aug 1, 2022

/hold
wait #5686 to add env var description

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 1, 2022
feloy added 2 commits August 2, 2022 12:08
@feloy
Use devfile proxy for odo init --devfile-registry

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5e82472
@feloy
Document DEVFILE_PROXY env var
ec8e5c2
@feloy feloy force-pushed the tests/devfile-proxy-for-devfile-registry-flag branch from 25fc8d8 to ec8e5c2 Compare August 2, 2022 10:12
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 2, 2022
@feloy feloy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feloy
Copy link
Contributor Author

feloy commented Aug 2, 2022

Can we please document this somewhere?

Maybe we could merge #5686 even if it is not completed and add this new env variable to the list. I think that even a list of the env variables that odo uses is still useful, we can add a description later. I'm starting to get worried about all the hidden settings hat we keep adding into odo that are nowhere documented

I added doc for the environment variable.

There is some doc about the Devfile proxy at https://github.com/redhat-developer/odo/blob/main/scripts/ansible/kubernetes-cluster/README.md#devfile-registry-reverse-proxy

@feloy feloy closed this Aug 2, 2022
@feloy feloy reopened this Aug 2, 2022
@feloy feloy closed this Aug 3, 2022
@feloy feloy reopened this Aug 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dharmit
dharmit reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/website/docs/overview/configure.md
| -------------------------- | --------------------------------------------------------------------------------------------------------------------- |
| `PODMAN_CMD` | The command executed to run the local podman binary. `podman` by default |
| `DOCKER_CMD` | The command executed to run the local docker binary. `docker` by default |
| `ODO_BOOTSTRAPPER_IMAGE` | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this env var anymore. IMO, it should be removed from the docs.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 4, 2022
@valaparthvi
Copy link
Contributor

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 390f736 into redhat-developer:main Aug 4, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @cdrage
Use devfile proxy for odo init --devfile-registry (redhat-developer#5995
25b95e3 
)

* Use devfile proxy for odo init --devfile-registry

* Document DEVFILE_PROXY env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit

@rnapoles-rh rnapoles-rh

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@feloy @kadel @valaparthvi @dharmit