Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Bump k8s.io/client-go from 0.23.2 to 0.24.3 #5949

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 18, 2022

Bumps k8s.io/client-go from 0.23.2 to 0.24.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs kind/task Issue is actionable task ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 18, 2022
@netlify
Copy link

netlify bot commented Jul 18, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6a54edc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62e39d7e739d2c000938853f

@dependabot dependabot bot requested review from dharmit and feloy July 18, 2022 02:22
@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2022

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2022

OpenShift Tests on commit dc78cb4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2022

Kubernetes Tests on commit dc78cb4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2022

Windows Tests (OCP) on commit dc78cb4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2022

Unit Tests on commit dc78cb4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2022

Validate Tests on commit dc78cb4 finished successfully.
View logs: TXT HTML

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.24.3 branch 3 times, most recently from c386ac6 to 4617fe3 Compare July 22, 2022 09:28
@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dharmit for approval by writing /assign @dharmit in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l
Copy link
Member

rm3l commented Jul 22, 2022

/hold

Need to update the scripts/generate-mod.sh script as well.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 22, 2022
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.24.3 branch 2 times, most recently from a405510 to 316a573 Compare July 23, 2022 07:42
dependabot bot and others added 3 commits July 29, 2022 10:24
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.2 to 0.24.3.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.23.2...v0.24.3)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…od.sh' script

It was updated with the bump of a 'k8s.io/*' library, but since we also use it directly,
it makes sense to have it declared explicitly.

Signed-off-by: Armel Soro <[email protected]>
@rm3l rm3l force-pushed the dependabot/go_modules/k8s.io/client-go-0.24.3 branch from 316a573 to 6a54edc Compare July 29, 2022 08:42
@rm3l
Copy link
Member

rm3l commented Aug 1, 2022

/hold cancel

Made the necessary changes, so this should be ready to review.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 1, 2022
@rm3l rm3l closed this Aug 1, 2022
@rm3l rm3l reopened this Aug 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@redhat-developer redhat-developer deleted a comment from dependabot bot Aug 1, 2022
@rm3l
Copy link
Member

rm3l commented Aug 1, 2022

✗  Downloading starter project "nodejs-starter" [21ms]
   ✗  unable to download starter project "nodejs-starter": unexpected client error: unexpected requesting "https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack" status code: 429
  the command failed, the devfile has been removed from current directory

/test v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2022

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-integration-e2e 6a54edc link true /test v4.10-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2022

A newer version of k8s.io/client-go exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Aug 30, 2022
@openshift-merge-robot
Copy link
Collaborator

@dependabot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Aug 30, 2022

@dependabot recreate

Recreating to check if a newer version is available, since #6060 updated this library already..

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2022

Superseded by #6066.

@dependabot dependabot bot closed this Aug 30, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/client-go-0.24.3 branch August 30, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs kind/task Issue is actionable task needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants