Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove odo preference registry update command #5853

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Remove odo preference registry update command #5853

merged 3 commits into from
Jun 23, 2022

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jun 21, 2022 •
edited
Loading

What type of PR is this:

What does this PR do / why we need it:
This PR removes odo preference registry update command.
Which issue(s) this PR fixes:

Fixes part of #5535

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2022

@valaparthvi: The label(s) area/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:
/area cleanup

What does this PR do / why we need it:
This PR removes odo preference registry update command.
Which issue(s) this PR fixes:

Fixes #5535

PR acceptance criteria:

  • Unit test

  • Integration test

  • [] Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rm3l and rnapoles-rh June 21, 2022 13:00
@netlify
Copy link

netlify bot commented Jun 21, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit ca5f645
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62b30bebe7005e0008cdafe5
😎 Deploy Preview https://deploy-preview-5853--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@valaparthvi valaparthvi force-pushed the remove-preference-update branch from c8db644 to ba1f8fd Compare June 21, 2022 13:03
@odo-robot
Copy link

odo-robot bot commented Jun 21, 2022 •
edited
Loading

Unit Tests on commit 3cc1c5a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2022 •
edited
Loading

Kubernetes Tests on commit 3cc1c5a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2022 •
edited
Loading

OpenShift Tests on commit 3cc1c5a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2022 •
edited
Loading

Windows Tests (OCP) on commit 3cc1c5a finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the remove-preference-update branch from ba1f8fd to 1595698 Compare June 21, 2022 13:29
@odo-robot
Copy link

odo-robot bot commented Jun 21, 2022 •
edited
Loading

Validate Tests on commit 3cc1c5a finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the remove-preference-update branch from 1595698 to 07fbe76 Compare June 21, 2022 14:03
cdrage
cdrage approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 21, 2022
@valaparthvi valaparthvi reopened this Jun 22, 2022
@dharmit
Copy link
Member

dharmit commented Jun 22, 2022

Fixes #5535

Does this PR completely fix the said issue or a part of it?

@dharmit
Copy link
Member

dharmit commented Jun 22, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 22, 2022
@valaparthvi valaparthvi mentioned this pull request Jun 22, 2022
Closed
7 tasks
@valaparthvi
Copy link
Contributor Author

Fixes #5535

Does this PR completely fix the said issue or a part of it?

Fixed it. thanks for catching it!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

@valaparthvi valaparthvi requested a review from rm3l June 22, 2022 12:40
@feloy
Copy link
Contributor

feloy commented Jun 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 23, 2022
@feloy
Copy link
Contributor

feloy commented Jun 23, 2022

/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 63e7a04 into redhat-developer:main Jun 23, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @rm3l @cdrage
Remove odo preference registry update command (redhat-developer#5853)
cbb477b 
* Remove odo preference registry update command

Signed-off-by: Parthvi Vala <[email protected]>

* Update pkg/registry/registry.go

Co-authored-by: Armel Soro <[email protected]>

* rm3l's review

Co-authored-by: Armel Soro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@rm3l rm3l Awaiting requested review from rm3l

Assignees

@cdrage cdrage

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valaparthvi @dharmit @feloy @rm3l @cdrage