Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventually list namespaces for test #5837

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Eventually list namespaces for test #5837

merged 1 commit into from
Jun 28, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 17, 2022

What type of PR is this:

/kind tests

Which issue(s) this PR fixes:

Fixes #5836

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit a827742
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62b01c5037bbe80009521c08

@feloy feloy requested review from rm3l and dharmit June 17, 2022 06:58
@openshift-ci openshift-ci bot requested a review from valaparthvi June 17, 2022 06:58
@dharmit
Copy link
Member

dharmit commented Jun 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 17, 2022
@odo-robot
Copy link

odo-robot bot commented Jun 17, 2022 •
edited
Loading

Unit Tests on commit eabfbf2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 17, 2022 •
edited
Loading

Kubernetes Tests on commit eabfbf2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 17, 2022 •
edited
Loading

Windows Tests (OCP) on commit eabfbf2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 17, 2022 •
edited
Loading

OpenShift Tests on commit eabfbf2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 17, 2022 •
edited
Loading

Validate Tests on commit eabfbf2 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 17, 2022
@feloy feloy force-pushed the bugfix-5836/eventually-list-project branch 2 times, most recently from d2ec1c7 to a827742 Compare June 20, 2022 07:05
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 20, 2022
@rm3l
Copy link
Member

rm3l commented Jun 20, 2022

@feloy If I understood correctly, tests are not passing on Prow because of redhat-developer/service-binding-operator#1172, right?

@rm3l rm3l mentioned this pull request Jun 20, 2022
Merged
5 tasks
@feloy
Copy link
Contributor Author

feloy commented Jun 20, 2022

@feloy If I understood correctly, tests are not passing on Prow because of redhat-developer/service-binding-operator#1172, right?

Yes, I think so

@feloy
Copy link
Contributor Author

feloy commented Jun 21, 2022

I think there has been a misunderstanding. IMO, the still failing tests (8 tests constantly failing) are due to redhat-developer/service-binding-operator#1172, but there are 2 flaky tests that should be fixed with this PR.

I'll wait for the fix on SBO, and reopen this PR if there are still flaky tests.

@valaparthvi
Copy link
Contributor

valaparthvi commented Jun 21, 2022 •
edited
Loading

I closed this PR by mistake, hadn't realized I'd done that. Feel free to open it @feloy.

@feloy feloy reopened this Jun 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valaparthvi
Copy link
Contributor

@feloy should we put this on hold until the SBO issue is resolved?

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2022

/test v4.10-integration-e2e

This fix is independent from the SBO problem. It tries to fix the problem when the listing of namespaces is not up to date.

I restart the tests as I can see some network errors

@valaparthvi
Copy link
Contributor

This fix is independent from the SBO problem. It tries to fix the problem when the listing of namespaces is not up to date.

I restart the tests as I can see some network errors

The test fixed by this PR seems to be passing. I'm inclined to merge this PR.

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2022

I can see the same failure on IBM Windows tests (from another PR):

https://cloud.ibm.com/devops/pipelines/929da3ed-6cad-4026-a847-7a8485f20fa4/582614a3-b910-4659-ac27-6288668c5fe6/a1d74ffa-3d39-4dbb-8583-b0a34f87f3bd/1b647bf2-5a73-485b-87de-29789ad66f1f/f4f3f320-fa08-4612-b4a9-3a86e3eefb28?env_id=ibm:yp:eu-de

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2022

SBO has just been updated to v1.1.1, running the tests again:

/test v4.10-integration-e2e

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2022 

There are no nodes that your pod can schedule to

/test v4.10-integration-e2e

@valaparthvi
Copy link
Contributor

valaparthvi commented Jun 24, 2022 •
edited
Loading

Failed to login as developer (link)

/retest-required

@feloy feloy mentioned this pull request Jun 24, 2022
Merged
3 tasks
@rm3l
Copy link
Member

rm3l commented Jun 28, 2022

Can we merge this PR?

@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2022

/test v4.10-integration-e2e

@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2022

Can we merge this PR?

For me yes it can be merged

@rm3l
Copy link
Member

rm3l commented Jun 28, 2022

Can we merge this PR?

For me yes it can be merged

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 28, 2022
@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2022

/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2022

/override ci/prow/unit

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit

In response to this:

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 2278569 into redhat-developer:main Jun 28, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @cdrage
Eventually list namespaces for test (redhat-developer#5837)
caac761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@dharmit dharmit Awaiting requested review from dharmit

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create/delete/list/set namespace/project test failing regularly on Prow
4 participants
@feloy @dharmit @rm3l @valaparthvi