When typing odo foobar --help should error out with invalid command #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
feloy
suggested changes
Jun 14, 2022
pkg/odo/cli/cli.go
Outdated
| rootCmd.SetHelpFunc(func(command *cobra.Command, args []string) { | ||
| // Simple way of checking to see if the command has a parent (if it doesn't, it does not exist) | ||
| if !command.HasParent() && len(args) > 0 { | ||
| fmt.Printf("unknown command '%s', type --help for a list of all commands\n", args[0]) |
There was a problem hiding this comment.
You should print in stderr instead
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind feature /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind bug **What does this PR do / why we need it:** When we type: ```sh odo foobar --help ``` We should error out that it's an invalid command. **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes redhat-developer#5439 **PR acceptance criteria:** - [X] Integration test **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm /override ci/prow/unit |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
lgtm
cdrage
added a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
…edhat-developer#5813) * When typing odo foobar --help should error out with invalid command <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind feature /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind bug **What does this PR do / why we need it:** When we type: ```sh odo foobar --help ``` We should error out that it's an invalid command. **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes redhat-developer#5439 **PR acceptance criteria:** - [X] Integration test **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]> * Send message to stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
When we type:
We should error out that it's an invalid command.
Which issue(s) this PR fixes:
Fixes #5439
PR acceptance criteria:
How to test changes / Special notes to the reviewer:
Signed-off-by: Charlie Drage [email protected]