add e2e tests #5778
add e2e tests #5778
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Signed-off-by: anandrkskd <[email protected]>
| helper.ReplaceString(filepath.Join(commonVar.Context, "devfile.yaml"), "nodejs-prj1-api-abhz", componentName) | ||
|
|
||
| //helper.ReplaceString(filepath.Join(commonVar.Context, "devfile.yaml"), "quay.io/unknown-account/myimage", "quay.io/repository/libpod/alpine") | ||
| stdout = helper.Cmd("odo", "deploy").AddEnv("PODMAN_CMD=echo").ShouldPass().Out() |
There was a problem hiding this comment.
It could be interesting to build the image for the e2e tests
There was a problem hiding this comment.
Not for this PR, but we should discuss this during a cabal
There was a problem hiding this comment.
I will create an issue for this one separately to track.
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd <[email protected]>
|
/restest |
Signed-off-by: anandrkskd <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: anandrkskd <[email protected]>
| deploymentName := "my-component" | ||
| serviceName := "my-cs" | ||
| getDeployArgs := []string{"get", "deployment", "-n", commonVar.Project} | ||
| getSVCArgs := []string{"get", "svc", "-n", commonVar.Project} |
There was a problem hiding this comment.
You can perhaps move these to the main Context since it's common for both the sub-contexts.
There was a problem hiding this comment.
Previously, Philippe recommended that we should define the these value close to tests where it's getting used.
cc @feloy
Signed-off-by: anandrkskd <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/retest |
|
/override prow/v4.10-integration-e2e IBM tests pass. |
|
@valaparthvi: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
* add e2e tests, add G107 in gosec as exception Signed-off-by: anandrkskd <[email protected]> * add error handling Signed-off-by: anandrkskd <[email protected]> * incorporate reviews Signed-off-by: anandrkskd <[email protected]> * error handling Signed-off-by: anandrkskd <[email protected]> * error handling Signed-off-by: anandrkskd <[email protected]> * disable G107 for tests only Signed-off-by: anandrkskd <[email protected]> * remove commented code Signed-off-by: anandrkskd <[email protected]> * remove tests redundant checks Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd [email protected]
/kind tests
What does this PR do / why we need it:
This PR adds e2e tests for odo.
Which issue(s) this PR fixes:
Fixes #5752
Fixes #5750
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: