Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused examples/yaml files #5758

Merged

Conversation

rnapoles-rh
Copy link
Contributor

What type of PR is this:
/kind cleanup

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #5412

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Integration tests should not fail

@netlify
Copy link

netlify bot commented May 19, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 3b7635f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/628625aee8018f0008f9cd1e
😎 Deploy Preview https://deploy-preview-5758--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2022

@rnapoles-rh: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:
/kind cleanup

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #5412

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Integration tests should not fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@odo-robot
Copy link

odo-robot bot commented May 19, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 19, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 19, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 19, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 19, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@rnapoles-rh rnapoles-rh requested review from valaparthvi and removed request for mohammedzee1000 May 20, 2022 13:07
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 23, 2022
@dharmit
Copy link
Member

dharmit commented May 23, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 23, 2022
@rnapoles-rh
Copy link
Contributor Author

/test v4.10-integration-e2e

@dharmit
Copy link
Member

dharmit commented May 24, 2022

/override v4.10-integration-e2e

'cause ibm cloud k8s & ocp tests are passing.

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

@dharmit: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • v4.10-integration-e2e

Only the following contexts were expected:

  • Kubernetes Integration Tests/Kubernetes Integration Tests
  • OpenShift Integration tests/OpenShift Integration tests
  • Unit Tests/Unit Tests
  • ci/prow/unit
  • ci/prow/v4.10-images
  • ci/prow/v4.10-integration-e2e
  • ci/prow/v4.11-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.10-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • tide
  • validator/Validate

In response to this:

/override v4.10-integration-e2e

'cause ibm cloud k8s & ocp tests are passing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit
Copy link
Member

dharmit commented May 24, 2022

/override v4.10-integration-e2e

'cause ibm cloud k8s & ocp tests are passing.

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.10-integration-e2e

In response to this:

/override v4.10-integration-e2e

'cause ibm cloud k8s & ocp tests are passing.

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 44203d7 into redhat-developer:main May 24, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup examples directory
4 participants