Delete dev resources only when stopping Dev session #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
dharmit
suggested changes
May 19, 2022
Co-authored-by: Dharmit Shah <[email protected]>
|
/lgtm |
openshift-ci
bot
added
the
lgtm
rm3l
reviewed
May 19, 2022
| @@ -41,6 +41,9 @@ In the above example, three things have happened: | |||
| * `odo` has port-forwarded your application for local accessability | |||
| * `odo` will watch for changes in the current directory and rebuild the application when changes are detected | |||
|
|
|||
| You can press Ctrl-c at any time to terminate the development session. The command can take a few moment to terminate, as it | |||
There was a problem hiding this comment.
I think it should be: "can take a moment" or "can take a few moments".
But maybe a native English speaker could correct me? @dharmit ? ^^
Suggested change
| You can press Ctrl-c at any time to terminate the development session. The command can take a few moment to terminate, as it | |
| You can press Ctrl-c at any time to terminate the development session. The command can take a few moments to terminate, as it |
There was a problem hiding this comment.
I did notice it, but didn't bring it up. However, I completely agree with your take on this.
docs/website/versioned_docs/version-3.0.0/command-reference/dev.md
Outdated
Show resolved
Hide resolved
openshift-ci
bot
removed
the
lgtm
feloy
force-pushed
the
bugfix-5700/delete-dev-only
branch
from
2a36ba7 to
b207513
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
the
lgtm
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
…#5751) * Add integration test * Fix issue * doc * Update pkg/component/delete/delete.go Co-authored-by: Dharmit Shah <[email protected]> * Review Co-authored-by: Dharmit Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5700
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: