Implement odo set namespace/project
#5744
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
the
kind/feature
openshift-ci
bot
added
the
lgtm
| checkNsDeletionFunc(true) | ||
| It(fmt.Sprintf("should successfully delete the %s synchronously with --wait", commandName), func() { | ||
| checkNsDeletionFunc([]string{"--wait"}, func() { | ||
| Expect(commonVar.CliRunner.GetAllNamespaceProjects()).ShouldNot(ContainElement(namespace)) |
There was a problem hiding this comment.
Could you try to use kubectl get namespace <name> instead of the list?
We are experiencing flaky errors where the namespace is in the list. Is it due to some cache or some delay in the list update?
There was a problem hiding this comment.
Ok. I remember I tried to use one of the existing methods (one of helper.GetNamespaceProject or helper.CheckNamespaceProjectExists) but couldn't because they expect that the "kubectl get namespace <name>" command passes. So I couldn't use it to check that a namespace no longer exists. That's why I tried with the list.
But let me fix that.
There was a problem hiding this comment.
We are experiencing flaky errors where the namespace is in the list. Is it due to some cache or some delay in the list update?
I quickly tested on a cluster-bot cluster, and from what I understand from the API Server response headers, kubectl could indeed cache responses, but the response must be validated with the origin server before each reuse. So to me, on the kubectl client side, responses are potentially cached but always checked for content updates.
❯ kubectl get ns --v=8
Alias tip: k get ns --v=8
I0516 13:41:26.906356 420945 loader.go:372] Config loaded from file: /home/asoro/work/tmp/cluster-bot/config
I0516 13:41:26.908921 420945 round_trippers.go:463] GET https://127.0.0.1:43051/api/v1/namespaces?limit=500
I0516 13:41:26.908931 420945 round_trippers.go:469] Request Headers:
I0516 13:41:26.908943 420945 round_trippers.go:473] Accept: application/json;as=Table;v=v1;g=meta.k8s.io,application/json;as=Table;v=v1beta1;g=meta.k8s.io,application/json
I0516 13:41:26.908951 420945 round_trippers.go:473] User-Agent: kubectl/v1.24.0 (linux/amd64) kubernetes/4ce5a89
I0516 13:41:26.914511 420945 round_trippers.go:574] Response Status: 200 OK in 5 milliseconds
I0516 13:41:26.914524 420945 round_trippers.go:577] Response Headers:
I0516 13:41:26.914534 420945 round_trippers.go:580] Audit-Id: 8dcfdfbf-47b7-40aa-a89e-e4547f653c8d
I0516 13:41:26.914544 420945 round_trippers.go:580] Cache-Control: no-cache, private
I0516 13:41:26.914554 420945 round_trippers.go:580] Content-Type: application/json
I0516 13:41:26.914561 420945 round_trippers.go:580] X-Kubernetes-Pf-Flowschema-Uid: 915fbd93-565d-4fc2-8975-4dae2b4dcbea
I0516 13:41:26.914568 420945 round_trippers.go:580] X-Kubernetes-Pf-Prioritylevel-Uid: 98f3f965-3d3d-44fc-99d8-d6428ea1ffb3
I0516 13:41:26.914576 420945 round_trippers.go:580] Date: Mon, 16 May 2022 11:41:26 GMT
I don't know how the --wait flag behaves exactly under the hood, but maybe we are not guaranteed that the namespace is really deleted when the project.Delete method returns?
Anyways, I am trying to rely on the kubectl get namespace <name> command instead.
There was a problem hiding this comment.
Another cause would be that, in the sources (kclient/project.go), we are waiting for the deletion of the project, not the namespace
There was a problem hiding this comment.
But a Project is also a Namespace, no?
Anyways, the latest commit I've pushed no longer uses the list to check for the namespace. I've also rebased the branch to get the other fix related to the Devfile metadata version.
Let's see how it goes now 🤞🏿
…ce,project} <name>' For some reason, checking by listing all namespaces/projects could end up returning an outdated list.
rm3l
force-pushed
the
5525-odo-create-delete-list-namespace_set
branch
from
6afaa5c to
c8f21e9
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
* Implement 'set namespace/project'
* Add doc for 'set namespace/project'
* Add integration tests
* Group tests in cmd_namespace_test.go to make them easier to understand and debug
* Restructure 'set namespace' tests
* Check for namespace/project existence with '{oc,kubectl} get {namespace,project} <name>'
For some reason, checking by listing all namespaces/projects could end up returning an outdated list.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR continues the work started by @valaparthvi by implementing the missing
odo set namespace/projectcommand.Which issue(s) this PR fixes:
Relates to #5525
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Note: as depicted in the acceptance criteria, if
odo set namespaceis executed inside a component directory, it should show a warning, that this won't update the namespace of the existing component.