Some outputs should error 1 not error 0 #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt.Printf errors out with checkout code 0. However, there are some prompts (this component doens't exist, this application doesn't exist) that error out with 0, they should error with checkout code 1 (using fmt.Errorf). This creates incorrect output for PS1 / `odo utils terminal` code as it creates scenarios where there is a false error code output: ```sh if [ $? != 0 ]; then APP="Unable to retrieve app" else APP=$(echo $APP_GET | sed "s/The current application is: //g") fi ```
|
After discussion in #549 I'm going to close this (for now), but I'll still keep this branch just-in-case for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.Printf errors out with checkout code 0. However, there are some
prompts (this component doens't exist, this application doesn't exist)
that error out with 0, they should error with checkout code 1 (using
fmt.Errorf).
This creates incorrect output for PS1 /
odo utils terminalcode as itcreates scenarios where there is a false error code output: