-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix PATH for odo binary #5702
fix PATH for odo binary #5702
Conversation
Signed-off-by: anandrkskd <[email protected]>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed!
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@anandrkskd Thanks for this fix. LGTM, but out of curiosity, do you know what could have caused it to have other binaries in the PATH? |
/override ci/prow/v4.10-integration-e2e |
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/v4.10-integration-e2e |
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I was using the Windows machine to do some testing before enabling the CI, for which I had to put odo binary in the path and I forgot to remove the odo binary after my testing. |
Thanks. |
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd [email protected]
What type of PR is this:
/kind tests
What does this PR do / why we need it:
This PR will make sure to use correct odo binary for tests even if there are other binary in the PATH
Which issue(s) this PR fixes:
Fixes #5683
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: