Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PATH for odo binary #5702

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd [email protected]

What type of PR is this:
/kind tests

What does this PR do / why we need it:
This PR will make sure to use correct odo binary for tests even if there are other binary in the PATH
Which issue(s) this PR fixes:

Fixes #5683

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: anandrkskd <[email protected]>
@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit f9acb77
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/626a8f06ced3fc0008ec2180

@openshift-ci openshift-ci bot requested review from mohammedzee1000 and rm3l April 28, 2022 12:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Apr 28, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 28, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 28, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 28, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Apr 28, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 28, 2022
@rm3l
Copy link
Member

rm3l commented Apr 28, 2022

@anandrkskd Thanks for this fix. LGTM, but out of curiosity, do you know what could have caused it to have other binaries in the PATH?

@feloy
Copy link
Contributor

feloy commented Apr 28, 2022

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Apr 28, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Apr 28, 2022

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3f40f0a into redhat-developer:main Apr 28, 2022
@anandrkskd anandrkskd deleted the fix-5683 branch April 29, 2022 05:05
@anandrkskd
Copy link
Contributor Author

@anandrkskd Thanks for this fix. LGTM, but out of curiosity, do you know what could have caused it to have other binaries in the PATH?

I was using the Windows machine to do some testing before enabling the CI, for which I had to put odo binary in the path and I forgot to remove the odo binary after my testing.
With this, I think we won't face this issue again.

@rm3l
Copy link
Member

rm3l commented Apr 29, 2022

@anandrkskd Thanks for this fix. LGTM, but out of curiosity, do you know what could have caused it to have other binaries in the PATH?

I was using the Windows machine to do some testing before enabling the CI, for which I had to put odo binary in the path and I forgot to remove the odo binary after my testing. With this, I think we won't face this issue again.

Thanks.

cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows tests not running the right odo binary
4 participants