-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favor use of "allowlist" and "denylist" in wwhrd
license check config
#5699
Favor use of "allowlist" and "denylist" in wwhrd
license check config
#5699
Conversation
This is the recommended way of configuring wwhrd [1]. Also, those are more inclusive terms in line with Red Hat recommendations [2]. [1] https://github.com/frapposelli/wwhrd#configuration-file [2] https://www.redhat.com/en/blog/making-open-source-more-inclusive-eradicating-problematic-language
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed!
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test v4.10-integration-e2e |
/override ci/prow/v4.10-integration-e2e |
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…redhat-developer#5699) This is the recommended way of configuring wwhrd [1]. Also, those are more inclusive terms in line with Red Hat recommendations [2]. [1] https://github.com/frapposelli/wwhrd#configuration-file [2] https://www.redhat.com/en/blog/making-open-source-more-inclusive-eradicating-problematic-language
What does this PR do / why we need it:
Stumbled upon this while working on #5567
This changes the terminology used in
.wwhrd.yml
, as this is the recommended way of configuring wwhrd [1].Also, those are more inclusive terms in line with Red Hat recommendations [2].
[1] https://github.com/frapposelli/wwhrd#configuration-file
[2] https://www.redhat.com/en/blog/making-open-source-more-inclusive-eradicating-problematic-language
Which issue(s) this PR fixes:
No related issue, as this was very quick to update.
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Both
make validate-vendor-licenses
andmake validate
should pass.