Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor use of "allowlist" and "denylist" in wwhrd license check config #5699

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Apr 27, 2022

What does this PR do / why we need it:
Stumbled upon this while working on #5567

This changes the terminology used in .wwhrd.yml, as this is the recommended way of configuring wwhrd [1].
Also, those are more inclusive terms in line with Red Hat recommendations [2].

[1] https://github.com/frapposelli/wwhrd#configuration-file
[2] https://www.redhat.com/en/blog/making-open-source-more-inclusive-eradicating-problematic-language

Which issue(s) this PR fixes:
No related issue, as this was very quick to update.

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Both make validate-vendor-licenses and make validate should pass.

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit dfe365d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62690d3161e4950008f5def0

@openshift-ci openshift-ci bot requested review from dharmit and feloy April 27, 2022 09:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Apr 27, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 27, 2022
@rm3l rm3l added the kind/task Issue is actionable task label Apr 27, 2022
@rm3l
Copy link
Member Author

rm3l commented Apr 27, 2022

/test v4.10-integration-e2e

@feloy
Copy link
Contributor

feloy commented Apr 27, 2022

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cluster

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dbfde00 into redhat-developer:main Apr 27, 2022
@rm3l rm3l deleted the switch_to_allowlist_denylist_in_wwhrd_license_check_config branch April 27, 2022 12:09
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/task Issue is actionable task lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants