Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devfiles information and used images for ppc64le #5662

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

Mahima-Gaikwad
Copy link
Contributor

@Mahima-Gaikwad Mahima-Gaikwad commented Apr 14, 2022

**What type of PR is this:

What does this PR do / why we need it:**

For Power, we have verified latest languages and runtimes refer to https://github.com/devfile/registry/tree/main/stacks. So this PR is to update document https://odo.dev/docs/tutorials/deploying-a-devfile-using-odo-on-IBM-Z-and-Power for Power.
All the added type of languages have been verified on Power.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Documentation

How to test changes / Special notes to the reviewer:

/area system-PZ

@openshift-ci openshift-ci bot added the area/System-PZ Issues related to IBM System Z and System P label Apr 14, 2022
@openshift-ci openshift-ci bot requested review from dharmit and valaparthvi April 14, 2022 04:09
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

Hi @Mahima-Gaikwad. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit c6f23bf
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62579e6237ab3d0008e5b57a
😎 Deploy Preview https://deploy-preview-5662--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@valaparthvi
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Apr 14, 2022
@valaparthvi
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 14, 2022
@valaparthvi
Copy link
Contributor

@Mahima-Gaikwad This PR is good to go, right?
If yes, then feel free to unhold this PR.

@valaparthvi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Apr 14, 2022
@feloy
Copy link
Contributor

feloy commented Apr 14, 2022

/override Kubernetes Integration Tests/Kubernetes Integration Tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

@feloy: Overrode contexts on behalf of feloy: Kubernetes Integration Tests/Kubernetes Integration Tests

In response to this:

/override Kubernetes Integration Tests/Kubernetes Integration Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Apr 14, 2022

/override OpenShift Integration tests/OpenShift Integration tests
/override Unit Tests/Unit Tests
/override validator/Validate

Doc only
Tests failing because of quote in PR title

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

@feloy: Overrode contexts on behalf of feloy: OpenShift Integration tests/OpenShift Integration tests, Unit Tests/Unit Tests, validator/Validate

In response to this:

/override OpenShift Integration tests/OpenShift Integration tests
/override Unit Tests/Unit Tests
/override validator/Validate

Doc only
Tests failing because of quote in PR title

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mahima-Gaikwad Mahima-Gaikwad changed the title Update devfiles' information and used images for ppc64le Update devfiles information and used images for ppc64le Apr 14, 2022
@Mahima-Gaikwad
Copy link
Contributor Author

@Mahima-Gaikwad This PR is good to go, right? If yes, then feel free to unhold this PR.

Yes, PR good to go.

@valaparthvi
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 78e7415 into redhat-developer:main Apr 19, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants