Fix issue with build-images and deploy not working with Docker if optional buildContext field is not set in Devfile (#5600)
#5657
Conversation
Per the Devfile spec [1], `buildContext` should be optional. [1] https://devfile.io/docs/devfile/2.2.0/user-guide/api-reference/
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
changed the title
build-images and deploy not working with Docker if optional buildContext field is not set in Devfilebuild-images and deploy not working with Docker if optional buildContext field is not set in Devfile (#5600)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.10-integration-e2e Looks like infra problems on Prow, and IBM Cloud tests are passing. |
|
@rm3l: rm3l unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test v4.10-integration-e2e |
rm3l
deleted the
5600-odo-build-images-and-odo-deploy-do-not-work-with-docker-if-optional-buildcontext-field-is-not-set-in-devfile
branch
… optional `buildContext` field is not set in Devfile (redhat-developer#5600) (redhat-developer#5657) * Add unit test highlighting the issue * Add integration tests to both `build-images` and `deploy` highlighting the issue * Use the Devfile directory as default build context path if not defined Per the Devfile spec [1], `buildContext` should be optional. [1] https://devfile.io/docs/devfile/2.2.0/user-guide/api-reference/ * Quote the build context path value
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This makes the build context directory for Docker (and Podman) default to the Devfile parent directory, if not set.
Which issue(s) this PR fixes:
Fixes #5600
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See reproduction steps detailed in #5600 (comment)