[Hotfix] Always ignore command and args defined in Devfile container components
#5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents This is a hotfix for [1], until a proper fix is implemented, which would consist in keeping using supervisord as pid1, and executing the command with args "on the side" as a separate process. [1] redhat-developer#5620
|
@rm3l: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
rm3l
changed the title
command and args fields in Devfile container componentscommand and args defined in Devfile container components
feloy
approved these changes
Apr 7, 2022
openshift-ci
bot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rm3l
deleted the
5620-odo-is-failing-when-devfile-container-component-defines-command
branch
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 10, 2022
…e container components (redhat-developer#5639)" This reverts commit 13bbc37.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 11, 2022
…e container components (redhat-developer#5639)" This reverts commit 13bbc37.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 11, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 12, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 12, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 12, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 12, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 13, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 14, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 16, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 16, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 18, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 19, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 19, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 24, 2022
…n Devfile container components (redhat-developer#5639)"" This reverts commit f6aea00.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 25, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 25, 2022
…n Devfile container components (redhat-developer#5639)"" This reverts commit f6aea00.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 27, 2022
…e container components (redhat-developer#5639)" This partially reverts commit 13bbc37. The integration tests that had been written as part of 13bbc37 have been kept, and will be reworked as part of this issue.
rm3l
added a commit
to rm3l/odo
that referenced
this pull request
May 27, 2022
…n Devfile container components (redhat-developer#5639)"" This reverts commit f6aea00.
3 tasks
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
…ner components (redhat-developer#5639) * Reproduce the issue via a test case with `odo dev` * Always ignore `command` and `args` fields in Devfile container components This is a hotfix for [1], until a proper fix is implemented, which would consist in keeping using supervisord as pid1, and executing the command with args "on the side" as a separate process. [1] redhat-developer#5620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/kind hotfix
What does this PR do / why we need it:
Before this fix, running
odo devwould not succeed if the Devfile defines a container component withcommandorargs.Which issue(s) this PR fixes:
Fixes #5620
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: