refactoring generic-test #5628

rnapoles-rh · 2022-04-05T12:37:52Z

What type of PR is this:
/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #5324

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

netlify · 2022-04-05T12:37:58Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`2854903`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6267f99de32c2100080bf1f5

odo-robot · 2022-04-05T12:44:40Z

Unit Tests on commit 41b3dc4 finished successfully.
View logs: TXT HTML

odo-robot · 2022-04-05T12:50:03Z

Kubernetes Tests on commit 41b3dc4 finished successfully.
View logs: TXT HTML

odo-robot · 2022-04-05T12:50:31Z

OpenShift Tests on commit 41b3dc4 finished successfully.
View logs: TXT HTML

odo-robot · 2022-04-05T12:54:12Z

Validate Tests on commit 41b3dc4 finished successfully.
View logs: TXT HTML

tests/integration/generic_test.go

valaparthvi · 2022-04-06T06:54:08Z

tests/integration/generic_test.go

 	})

+	// Disabling test temporarely while odo registry gets developed


Suggested change

// Disabling test temporarely while odo registry gets developed

// TODO: Disabling test temporarily while odo registry gets developed

valaparthvi · 2022-04-06T06:54:28Z

tests/integration/generic_test.go

+	// 	})
+	// })
+
+	// Disabling test temporarely while odo registry gets developed


Suggested change

// Disabling test temporarely while odo registry gets developed

// TODO: Disabling test temporarily while odo registry gets developed

valaparthvi · 2022-04-06T07:28:46Z

tests/integration/generic_test.go

+	When("deleting two projects one after the other", func() {
+		It("should be able to delete them sequentially", func() {
 			project1 := helper.CreateRandProject()
 			project2 := helper.CreateRandProject()

-			helper.DeleteProject(project2)
 			helper.DeleteProject(project1)
+			helper.DeleteProject(project2)
 		})
-	})
-
-	Context("When deleting three project one after the other in opposite order", func() {
-		It("should be able to delete", func() {
+		It("should be able to delete them in any order", func() {
 			project1 := helper.CreateRandProject()
 			project2 := helper.CreateRandProject()
 			project3 := helper.CreateRandProject()

-			helper.DeleteProject(project1)
 			helper.DeleteProject(project2)
+			helper.DeleteProject(project1)
 			helper.DeleteProject(project3)
-
 		})
 	})


#5406 (comment)

feloy · 2022-04-06T07:37:13Z

@rnapoles-rh Could you add these tests to .ibm/pipelines/ so they are executed on the Kubernetes and/or OpenShift clusters on IBM Cloud?

rnapoles-rh · 2022-04-07T21:03:50Z

@rnapoles-rh Could you add these tests to .ibm/pipelines/ so they are executed on the Kubernetes and/or OpenShift clusters on IBM Cloud?

Sure thing

feloy · 2022-04-08T13:06:00Z

@rnapoles-rh You get an error running these tests on Kubenetes, because of a known issue: #5650
Could you set this test for OpenShift only?

odo generic
/workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:12
  when executing odo version command
  /workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:146
    should show the version of odo major components including server login URL [It]
    /workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:152

    Expected
        <bool>: false
    to be true

anandrkskd · 2022-04-12T06:27:00Z

.ibm/pipelines/openshift-tests.sh

@@ -20,6 +20,7 @@ cleanup_namespaces
    make test-cmd-login-logout
    make test-cmd-project
    make test-e2e-devfile
+    make test-generic


@rnapoles-rh I don't think this is required as generic tests are getting tested in make test-integration test suite.

anandrkskd · 2022-04-12T06:27:31Z

.ibm/pipelines/kubernetes-tests.sh

@@ -17,6 +17,7 @@ cleanup_namespaces
    make test-interactive
    make test-e2e-devfile
    make test-cmd-project
+    make test-generic


@rnapoles-rh I don't think this is required as generic tests are getting tested in make test-integration test suite.

But we are not running make test-integration itself

tests/integration/generic_test.go

rnapoles-rh · 2022-04-26T13:43:32Z

@rnapoles-rh You get an error running these tests on Kubenetes, because of a known issue: #5650 Could you set this test for OpenShift only?

odo generic
/workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:12
  when executing odo version command
  /workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:146
    should show the version of odo major components including server login URL [It]
    /workspace/5142e227-52f8-4283-98ff-69b75dcb1e93/tests/integration/generic_test.go:152

    Expected
        <bool>: false
    to be true

Right, skipping as needed for Kubernetes cluster

…shift-tests.sh as it runs test-integration

sonarqubecloud · 2022-04-26T13:55:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.6% Duplication

odo-robot · 2022-04-26T14:06:48Z

Windows Tests (OCP) on commit 41b3dc4 finished successfully.
View logs: TXT HTML

feloy · 2022-04-28T13:35:29Z

/approve

openshift-ci · 2022-04-28T13:35:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anandrkskd · 2022-04-28T13:38:52Z

/lgtm

rnapoles-rh · 2022-04-28T14:50:39Z

Infra error: Ginkgo timed out waiting for all parallel nodes to report back!
/test v4.10-integration-e2e

feloy · 2022-04-28T19:32:25Z

/override ci/prow/v4.10-integration-e2e
IBM Cloud tests pass

openshift-ci · 2022-04-28T19:32:28Z

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
IBM Cloud tests pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* rebasing * Incorporated additional feedback, removed make test-generic from openshift-tests.sh as it runs test-integration

openshift-ci bot added the kind/tests label Apr 5, 2022

openshift-ci bot requested review from feloy and valaparthvi April 5, 2022 12:38

valaparthvi mentioned this pull request Apr 6, 2022

refactoring test generic-test #5406

Closed

2 tasks

valaparthvi suggested changes Apr 6, 2022

View reviewed changes

openshift-ci bot assigned valaparthvi Apr 6, 2022

rnapoles-rh force-pushed the 5324-test-generic branch from daf2d97 to 46387f7 Compare April 7, 2022 22:48

anandrkskd reviewed Apr 12, 2022

View reviewed changes

anandrkskd suggested changes Apr 12, 2022

View reviewed changes

tests/integration/generic_test.go Outdated Show resolved Hide resolved

openshift-ci bot assigned anandrkskd Apr 12, 2022

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 12, 2022

rebasing

7dfc5d4

Incorporated additional feedback, removed make test-generic from open…

2854903

…shift-tests.sh as it runs test-integration

rnapoles-rh force-pushed the 5324-test-generic branch from 46387f7 to 2854903 Compare April 26, 2022 13:54

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 26, 2022

feloy approved these changes Apr 28, 2022

View reviewed changes

openshift-ci bot assigned feloy Apr 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 28, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 28, 2022

valaparthvi approved these changes Apr 28, 2022

View reviewed changes

openshift-merge-robot merged commit f280a61 into redhat-developer:main Apr 28, 2022

cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022

refactoring generic-test (redhat-developer#5628)

3eb05d3

* rebasing * Incorporated additional feedback, removed make test-generic from openshift-tests.sh as it runs test-integration

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactoring generic-test #5628

refactoring generic-test #5628

rnapoles-rh commented Apr 5, 2022

netlify bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

valaparthvi Apr 6, 2022

rnapoles-rh Apr 7, 2022

valaparthvi Apr 6, 2022

valaparthvi Apr 6, 2022

rnapoles-rh Apr 7, 2022

feloy commented Apr 6, 2022

rnapoles-rh commented Apr 7, 2022

feloy commented Apr 8, 2022

anandrkskd Apr 12, 2022

anandrkskd Apr 12, 2022

feloy Apr 13, 2022

rnapoles-rh commented Apr 26, 2022

sonarqubecloud bot commented Apr 26, 2022

odo-robot bot commented Apr 26, 2022

feloy commented Apr 28, 2022

openshift-ci bot commented Apr 28, 2022

anandrkskd commented Apr 28, 2022

rnapoles-rh commented Apr 28, 2022

feloy commented Apr 28, 2022

openshift-ci bot commented Apr 28, 2022

		})

		// Disabling test temporarely while odo registry gets developed

	// Disabling test temporarely while odo registry gets developed
	// TODO: Disabling test temporarily while odo registry gets developed

refactoring generic-test #5628

refactoring generic-test #5628

Conversation

rnapoles-rh commented Apr 5, 2022

netlify bot commented Apr 5, 2022 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

odo-robot bot commented Apr 5, 2022 • edited Loading

odo-robot bot commented Apr 5, 2022 • edited Loading

odo-robot bot commented Apr 5, 2022 • edited Loading

odo-robot bot commented Apr 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feloy commented Apr 6, 2022

rnapoles-rh commented Apr 7, 2022

feloy commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnapoles-rh commented Apr 26, 2022

sonarqubecloud bot commented Apr 26, 2022

odo-robot bot commented Apr 26, 2022

feloy commented Apr 28, 2022

openshift-ci bot commented Apr 28, 2022

anandrkskd commented Apr 28, 2022

rnapoles-rh commented Apr 28, 2022

feloy commented Apr 28, 2022

openshift-ci bot commented Apr 28, 2022

netlify bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading

odo-robot bot commented Apr 5, 2022 •

edited

Loading