Create cleanup #5589

valaparthvi · 2022-03-24T13:13:49Z

What type of PR is this:
/kind code-refactoring

What does this PR do / why we need it:
This PR cleans up odo create and all of its references from odo.
Which issue(s) this PR fixes:

Fixes #5564

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:
You can review each commit independently, each one has a clear purpose.

netlify · 2022-03-24T13:13:54Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`9371ebf`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/623d7a49f217f9000994a0a3
😎 Deploy Preview	https://deploy-preview-5589--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2022-03-24T13:31:30Z

Unit Tests on commit 7dc9aa8 finished successfully.
View logs: TXT HTML

odo-robot · 2022-03-24T14:08:33Z

Kubernetes Tests on commit 7dc9aa8 finished successfully.
View logs: TXT HTML

odo-robot · 2022-03-24T14:19:01Z

OpenShift Tests on commit 7dc9aa8 finished successfully.
View logs: TXT HTML

odo-robot · 2022-03-24T15:07:05Z

Validate Tests on commit 7dc9aa8 finished successfully.
View logs: TXT HTML

feloy · 2022-03-24T16:18:29Z

tests/integration/devfile/cmd_devfile_push_test.go

@@ -35,7 +35,7 @@ var _ = Describe("odo devfile push command tests", func() {
 	When("creating a nodejs component", func() {
 		output := ""
 		BeforeEach(func() {
-			helper.Cmd("odo", "create", "--project", commonVar.Project, cmpName, "--devfile", helper.GetExamplePath("source", "devfiles", "nodejs", "devfile-registry.yaml")).ShouldPass()
+			helper.Cmd("odo", "init", "--name", cmpName, "--devfile-path", helper.GetExamplePath("source", "devfiles", "nodejs", "devfile-registry.yaml")).ShouldPass()


Feel free to completely remove all the problematic tests from this file (or all the file), as this file will be removed in the other PR #5570

feloy · 2022-03-24T16:19:41Z

tests/integration/devfile/cmd_devfile_url_test.go

 	"github.com/tidwall/gjson"

+	"github.com/redhat-developer/odo/tests/helper"


Feel free to remove this file, as it will be removed from the other PR #5561

feloy · 2022-03-24T16:19:57Z

tests/integration/devfile/cmd_dot_devfile_test.go

@@ -5,7 +5,7 @@ import (

 	. "github.com/onsi/ginkgo"

-	//We continued iterating on bracket pair guides. Horizontal lines now outline the scope of a bracket pair. Also, vertical lines now depend on the indentation of the code that is surrounded by the bracket pair.. "github.com/onsi/gomega"
+	// We continued iterating on bracket pair guides. Horizontal lines now outline the scope of a bracket pair. Also, vertical lines now depend on the indentation of the code that is surrounded by the bracket pair.. "github.com/onsi/gomega"


You can also remove this file

cdrage · 2022-03-24T18:58:52Z

Hey @valaparthvi I'm going to close #5575 as your PR directly influences. I'll keep yours open instead as you did a much better job cleaning up the tests!

… require it but cannot create it

Signed-off-by: Parthvi Vala <[email protected]>

sonarqubecloud · 2022-03-25T08:17:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.6% Duplication

valaparthvi · 2022-03-25T10:02:26Z

/override ci/prow/v4.10-integration-e2e

IBM cloud test passes for both K8s and OC.

openshift-ci · 2022-03-25T10:02:33Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

IBM cloud test passes for both K8s and OC.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cdrage · 2022-03-25T12:16:38Z

Tests pass, code looks good!

/lgtm

feloy · 2022-03-25T12:35:28Z

/approve

openshift-ci · 2022-03-25T12:35:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Cleanup create code * Add missing integration tests from odo create to odo init * Add CreateLocalEnv to create .odo/env/env.yaml file for commands that require it but cannot create it * Remove 'odo create' usages from integration tests * Remove create reference from the Makefile * REmove create doc from v3 Signed-off-by: Parthvi Vala <[email protected]> * Remove test files * Fix CI failure Signed-off-by: Parthvi Vala <[email protected]>

openshift-ci bot added the kind/code-refactoring label Mar 24, 2022

openshift-ci bot requested review from cdrage and feloy March 24, 2022 13:13

valaparthvi marked this pull request as draft March 24, 2022 13:15

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 24, 2022

valaparthvi force-pushed the create_cleanup branch from c9c2344 to b56275a Compare March 24, 2022 13:41

valaparthvi force-pushed the create_cleanup branch from b56275a to acca5fb Compare March 24, 2022 14:10

valaparthvi marked this pull request as ready for review March 24, 2022 14:55

valaparthvi force-pushed the create_cleanup branch from acca5fb to 48bdb2d Compare March 24, 2022 14:55

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 24, 2022

openshift-ci bot requested a review from kadel March 24, 2022 14:56

feloy suggested changes Mar 24, 2022

View reviewed changes

openshift-ci bot assigned feloy Mar 24, 2022

valaparthvi added 8 commits March 25, 2022 13:44

Cleanup create code

7995ec1

Add missing integration tests from odo create to odo init

33488c7

Add CreateLocalEnv to create .odo/env/env.yaml file for commands that…

04a331c

… require it but cannot create it

Remove 'odo create' usages from integration tests

47d7578

Remove create reference from the Makefile

1c370ee

REmove create doc from v3

d42d50a

Signed-off-by: Parthvi Vala <[email protected]>

Remove test files

242ed38

Fix CI failure

9371ebf

Signed-off-by: Parthvi Vala <[email protected]>

valaparthvi force-pushed the create_cleanup branch from 10a6bb1 to 9371ebf Compare March 25, 2022 08:16

valaparthvi requested a review from feloy March 25, 2022 10:09

openshift-ci bot assigned cdrage Mar 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 25, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 25, 2022

openshift-merge-robot merged commit 80d7cfd into redhat-developer:main Mar 25, 2022

rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create cleanup #5589

Create cleanup #5589

valaparthvi commented Mar 24, 2022

netlify bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

feloy Mar 24, 2022

feloy Mar 24, 2022

feloy Mar 24, 2022

cdrage commented Mar 24, 2022

sonarqubecloud bot commented Mar 25, 2022

valaparthvi commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

cdrage commented Mar 25, 2022

feloy commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

		"github.com/tidwall/gjson"

		"github.com/redhat-developer/odo/tests/helper"

Create cleanup #5589

Create cleanup #5589

Conversation

valaparthvi commented Mar 24, 2022

netlify bot commented Mar 24, 2022 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

odo-robot bot commented Mar 24, 2022 • edited Loading

odo-robot bot commented Mar 24, 2022 • edited Loading

odo-robot bot commented Mar 24, 2022 • edited Loading

odo-robot bot commented Mar 24, 2022 • edited Loading

feloy Mar 24, 2022

Choose a reason for hiding this comment

feloy Mar 24, 2022

Choose a reason for hiding this comment

feloy Mar 24, 2022

Choose a reason for hiding this comment

cdrage commented Mar 24, 2022

sonarqubecloud bot commented Mar 25, 2022

valaparthvi commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

cdrage commented Mar 25, 2022

feloy commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

netlify bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading

odo-robot bot commented Mar 24, 2022 •

edited

Loading