Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor devfile storage test #5275

Merged
merged 5 commits into from
Dec 14, 2021
Merged

refactor devfile storage test #5275

merged 5 commits into from
Dec 14, 2021

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?
/kind code-refactoring
/kind tests

What does this PR do / why we need it:
This PR refactors the test to use the new test flow

Which issue(s) this PR fixes:

Fixes #5211

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ Deploy Preview for odo-docusaurus-preview canceled.

🔨 Explore the source changes: 3e93686

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/61b71ee7e86cd700087d61ae

@feloy
Copy link
Contributor

feloy commented Dec 7, 2021

Kubernetes Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 7, 2021

Unit Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 7, 2021

OpenShift Tests finished.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor Author

/test v4.9-integration-e2e
platform failure : timeout

@anandrkskd
Copy link
Contributor Author

/test v4.9-integration-e2e
timeout failure

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

Kubernetes Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

Unit Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

OpenShift Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

Kubernetes Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

Unit Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 8, 2021

OpenShift Tests finished.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor Author

kubernetes test failed with a flake
/retest

@anandrkskd anandrkskd requested a review from feloy December 9, 2021 05:33
valaparthvi
valaparthvi suggested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only reviewed half of this, so there might be more reviews coming up. But, thank you for working on this :)

valaparthvi
valaparthvi suggested changes Dec 13, 2021
View reviewed changes
@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

Kubernetes Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

Unit Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

OpenShift Tests finished.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor Author

/test psi-unit-test-windows

1 similar comment
@anandrkskd
Copy link
Contributor Author

/test psi-unit-test-windows

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

Kubernetes Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

OpenShift Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

Unit Tests finished.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Dec 13, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 13, 2021
@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

2 similar comments
@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@openshift-merge-robot openshift-merge-robot merged commit fd16788 into redhat-developer:main Dec 14, 2021
rnapoles-rh pushed a commit to rnapoles-rh/odo that referenced this pull request Dec 14, 2021
@anandrkskd @rnapoles-rh
refactor devfile storage test (redhat-developer#5275)
9557f2f 
* refactor devfile storage test

Signed-off-by: anandrkskd <[email protected]>

* better explanotary statements, minor improvements

Signed-off-by: anandrkskd <[email protected]>

* minor improvements

Signed-off-by: anandrkskd <[email protected]>

* address requested changes on PR

Signed-off-by: anandrkskd <[email protected]>

* address requested changes on PR

Signed-off-by: anandrkskd <[email protected]>
@anandrkskd anandrkskd deleted the tests/devfile-storage-refactor branch October 13, 2022 11:11
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@valaparthvi valaparthvi valaparthvi requested changes

@dharmit dharmit Awaiting requested review from dharmit

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@feloy feloy

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor test-cmd-devfile-storage
5 participants
@anandrkskd @feloy @valaparthvi @rm3l @openshift-merge-robot