Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing # to a Changelog entry #4983

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Adds missing # to a Changelog entry #4983

merged 1 commit into from
Aug 11, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Aug 11, 2021

$subject

@dharmit dharmit mentioned this pull request Aug 11, 2021
Merged
5 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mik-dass
mik-dass approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Aug 11, 2021
@openshift-ci openshift-ci bot merged commit 16df430 into redhat-developer:main Aug 11, 2021
@dharmit dharmit deleted the nitpick-changelog-fix branch September 28, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dharmit @mik-dass