Only delete service from devfile

[feloy]

What type of PR is this?

/kind feature

What does this PR do / why we need it:

• odo service delete removes a service from the Devfile only, it does not undeploy it from the cluster.
  • Operator services
  • [n/c] Catalog services
• odo service list lists services in Devfile and/or deployed into the cluster
  • Operator services
  • [n/c] Catalog services
• odo push undeploys services managed by the current devfile not present in this devfile
  • Operator services
  • [n/c] Catalog services

Which issue(s) this PR fixes:

Fixes #4160

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• Update changelog

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

From a cluster with etcdoperator installed:

$ odo create nodejs
$ odo push
$ odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster myetcd

# at this point, the service should be declared in the devfile, but not deployed

$ odo service list
NAME                  MANAGED BY ODO               STATE        AGE
EtcdCluster/myetcd   Yes (nodejs-prj1-api-ixhx)   Not pushed   

$ odo push

# the service should be deployed

$ odo service list
NAME                  MANAGED BY ODO               STATE     AGE
EtcdCluster/myetcd   Yes (nodejs-prj1-api-ixhx)   Pushed    14s

$ odo service delete EtcdCluster/myetcd

# at this point, the service should be removed from the devfile, but not undeployed

$ odo service list
NAME                  MANAGED BY ODO               STATE             AGE
EtcdCluster/myetcd   Yes (nodejs-prj1-api-ixhx)   Deleted locally   1m7s

$ odo push

# the service should be undeployed

$ odo service list
 ✗  no operator backed services found in namespace: prj1

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test v4.7-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

I can see a difference in the content of the label app.kubernetes.io/instance for Service catalog service and Operator backed service.

For an Operator backed service, this is the name of the component from which the service is deployed:

apiVersion: etcd.database.coreos.com/v1beta2
kind: EtcdCluster
metadata:
  annotations:
    etcd.database.coreos.com/scope: clusterwide
  creationTimestamp: "2021-06-07T09:36:33Z"
  generation: 5
  labels:
    app: app
    app.kubernetes.io/instance: nodejs-prj1-api-xaeo
    app.kubernetes.io/managed-by: odo
    app.kubernetes.io/managed-by-version: v2.2.1
    app.kubernetes.io/part-of: app
  name: myetcd

For a service catalog service instance, this is the name of the service itself:

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ServiceInstance
metadata:
  creationTimestamp: "2021-06-07T09:50:03Z"
  finalizers:
  - kubernetes-incubator/service-catalog
  generation: 1
  labels:
    app: app
    app.kubernetes.io/instance: my-dh-postgresql-apb
    app.kubernetes.io/managed-by: odo
    app.kubernetes.io/managed-by-version: v2.2.1
    app.kubernetes.io/name: dh-postgresql-apb
    app.kubernetes.io/part-of: app
  name: my-dh-postgresql-apb

[feloy]

/test unit

[feloy]

/test psi-unit-test-windows
/test v4.7-integration-e2e

[feloy]

I moved this section after odo create as it is now (from a previous PR) necessary to have a component before to create a service.

[feloy]

/test psi-kubernetes-integration-e2e

[feloy]

/retest

[mik-dass]

/lgtm

[openshift-ci]

@feloy: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/psi-unit-test-mac	ca5cd36	link	/test psi-unit-test-mac
ci/prow/psi-unit-test-windows	ca5cd36	link	/test psi-unit-test-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[feloy]

/test v4.7-integration-e2e

[dharmit]

Timeout while spinning up the cluster - link to logs:

level=error
level=error msg=Error: timeout while waiting for state to become 'INSYNC' (timeout: 30m0s)
level=error
level=error msg=  on ../tmp/openshift-install-772034745/route53/base.tf line 56, in resource "aws_route53_record" "api_internal_alias":
level=error msg=  56: resource "aws_route53_record" "api_internal_alias" {
level=error
level=error
level=fatal msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: failed to complete the change