Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide GVR based on underlying cluster #4557

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Decide GVR based on underlying cluster #4557

merged 3 commits into from
Apr 1, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Mar 26, 2021

What type of PR is this?
/kind api-change
/kind bug

What does this PR do / why we need it:
Gets rid of the deprecated SelfLink attribute of a deployment and uses information available from the underlying cluster instead.

Which issue(s) this PR fixes:

Fixes #4431

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Along with OCP 4.6 and 4.7, odo link should work fine on OCP 4.8 and minikube started with minikube start --kubernetes-version=v1.20.2

@openshift-ci-robot openshift-ci-robot added kind/api-change kind/bug Categorizes issue or PR as related to a bug. labels Mar 26, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 26, 2021
@girishramnani
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2021
pkg/kclient/deployments.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2021
@kadel
Copy link
Member

kadel commented Mar 31, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 31, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 31, 2021
@dharmit
Copy link
Member Author

dharmit commented Mar 31, 2021

New changes are detected. LGTM label has been removed.

Did a force push to rebase on top of #4569

@kadel
Copy link
Member

kadel commented Apr 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 1, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel
Copy link
Member

kadel commented Apr 1, 2021

/override ci/prow/psi-kubernetes-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@kadel: Overrode contexts on behalf of kadel: ci/prow/psi-kubernetes-integration-e2e, ci/prow/psi-minishift-integration-e2e, ci/prow/psi-openshift-integration-e2e

In response to this:

/override ci/prow/psi-kubernetes-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9dae33e into redhat-developer:master Apr 1, 2021
@dharmit dharmit deleted the fix-4431 branch October 21, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception encountered when running odo link on minikube
6 participants