-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide GVR based on underlying cluster #4557
Decide GVR based on underlying cluster #4557
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
Decide GVR based on underlying cluster
Did a force push to rebase on top of #4569 |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/psi-kubernetes-integration-e2e |
@kadel: Overrode contexts on behalf of kadel: ci/prow/psi-kubernetes-integration-e2e, ci/prow/psi-minishift-integration-e2e, ci/prow/psi-openshift-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind api-change
/kind bug
What does this PR do / why we need it:
Gets rid of the deprecated
SelfLink
attribute of a deployment and uses information available from the underlying cluster instead.Which issue(s) this PR fixes:
Fixes #4431
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Along with OCP 4.6 and 4.7,
odo link
should work fine on OCP 4.8 and minikube started withminikube start --kubernetes-version=v1.20.2