Update installation document #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
kadel
reviewed
May 9, 2018
docs/installation.md
Outdated
| The latest MASTER build: | ||
|
|
||
| ```sh | ||
| brew install kadel/odo/odo -- HEAD |
There was a problem hiding this comment.
it should be brew install kadel/odo/odo --HEAD
docs/installation.md
Outdated
|
|
||
| Latest binaries build from git master are available at https://dl.bintray.com/odo/odo/latest/. | ||
| - macOS |
There was a problem hiding this comment.
it would be nice if those are links to corresponding sections
docs/installation.md
Outdated
|
|
||
| 1. Download the latest file from Bintray ([odo.exe](https://dl.bintray.com/odo/odo/latest/windows-amd64/odo.exe)) or from the latest release page on [GitHub](https://github.com/redhat-developer/odo/releases). | ||
| 2. Extract the file | ||
| 3. Add the location of extracted binary to your PATH environment variable by following [this Wiki page](https://github.com/redhat-developer/odo/wiki/Setting-PATH-variable-on-Windows). |
There was a problem hiding this comment.
Wouldn't it be better to have everything in one place?
I would consider moving that wiki page to this document.
cdrage
force-pushed
the
update-installation
branch
from
a427f86 to
0114422
Compare
Updates the installation document a little bit.
cdrage
force-pushed
the
update-installation
branch
from
0114422 to
a0f97f4
Compare
|
@kadel Updated with GOPATH documentation for Windows as well as addressing your concerns (added links to each header section) |
kadel
approved these changes
May 10, 2018
|
👍 thank you @cdrage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the installation document a little bit.