Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes duplication of devfile parsing and validation #4334

Closed
wants to merge 1 commit into from
Closed

Removes duplication of devfile parsing and validation #4334

wants to merge 1 commit into from

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Dec 30, 2020

What type of PR is this?
/kind cleanup
/kind code-refactoring

What does this PR do / why we need it:
Parsing and Validation of devfile already happens in "Complete"
function.

Which issue(s) this PR fixes:

Fixes NA
Part of #4298

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Tests should pass

Parsing and Validation of devfile already happens in "Complete"
function.
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 30, 2020
@girishramnani
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 30, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@dharmit
Copy link
Member Author

dharmit commented Dec 30, 2020

/hold

Some genuine failure with odo create --now.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Dec 30, 2020
@openshift-ci
Copy link

openshift-ci bot commented Dec 30, 2020

@dharmit: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-integration-e2e ccf2007 link /test v4.6-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@girishramnani
Copy link
Contributor

Any update on this PR?

@dharmit
Copy link
Member Author

dharmit commented Jan 29, 2021

Closing this since it looks like a genuine usage and not duplication of code.

/close

@openshift-ci-robot
Copy link
Collaborator

@dharmit: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit dharmit deleted the remove-duplicate-devfile-parse-validate branch January 29, 2021 10:08
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants