-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable odo log -f
tests
#3808
Disable odo log -f
tests
#3808
Conversation
@adisky In the third try i hit the same issue
|
unit test failed? |
test platform failure
/test unit |
New commit. Did not work Verified locally |
@arout not working failing locally in 4-5 try, commented |
Expect(err).To(BeNil()) | ||
Expect(match).To(BeTrue()) | ||
/* | ||
Flaky Test odo log -f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue and paste it here for reference. We will fix that after v2
e1dde96
to
4c40539
Compare
/lgtm |
Unit test failed |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm lets get this merged as other tests are failing because of this. |
What type of PR is this?
/kind failing-test
What does does this PR do / why we need it:
disable odo log -f tests, they are flaky, need some time to resolve them.
Which issue(s) this PR fixes:
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: