Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test script customisation and removing duplicates from push test #3645

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Test script customisation and removing duplicates from push test #3645

merged 2 commits into from
Aug 21, 2020

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind cleanup

What does does this PR do / why we need it:

Removing duplicates and code customisation in the script.

Which issue(s) this PR fixes:

Fixes - Part of #3385

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

make test-cmd-devfile-push should pass.

@prietyc123 prietyc123 changed the title Test script customisation and removing duplicates from push test [WIP] Test script customisation and removing duplicates from push test Jul 27, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 27, 2020
@prietyc123 prietyc123 force-pushed the CleanupPushTest branch 4 times, most recently from d557853 to 5db42e0 Compare August 10, 2020 12:03
@prietyc123 prietyc123 changed the title [WIP] Test script customisation and removing duplicates from push test Test script customisation and removing duplicates from push test Aug 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 10, 2020
@prietyc123 prietyc123 force-pushed the CleanupPushTest branch 3 times, most recently from 0dcaef0 to bb143ec Compare August 11, 2020 05:21
amitkrout
amitkrout suggested changes Aug 11, 2020
View reviewed changes
tests/integration/devfile/cmd_devfile_push_test.go
@@ -126,7 +126,7 @@ var _ = Describe("odo devfile push command tests", func() {
[]string{"stat", "/test/server.js"},
func(cmdOp string, err error) bool {
statErr = err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove statErr = err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also verifying that err should not have occured here - https://github.com/openshift/odo/pull/3645/files#diff-c127bd883f89dd3a7abff6183ad9921dR157 . So keeping this in the test

amitkrout
amitkrout reviewed Aug 11, 2020
View reviewed changes
tests/integration/devfile/cmd_devfile_push_test.go
@@ -126,7 +126,7 @@ var _ = Describe("odo devfile push command tests", func() {
[]string{"stat", "/test/server.js"},
func(cmdOp string, err error) bool {
statErr = err
return true
return err == nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for better approach

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This how we can avoid test script flakes.

@amitkrout
Copy link
Contributor 

 [odo]  ✗  Waiting for component to start [4m]
[odo] I0811 06:34:24.300685   16649 occlient.go:1823] Quitting collect events
[odo]  ✗  waited 4m0s but couldn't find running pod matching selector: 'deploymentconfig=gatuw-fniby'

/retest

@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #3645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3645   +/-   ##
=======================================
  Coverage   44.15%   44.15%           
=======================================
  Files         139      139           
  Lines       13345    13345           
=======================================
  Hits         5892     5892           
  Misses       6874     6874           
  Partials      579      579

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec93d3...f02c557. Read the comment docs.

@prietyc123 prietyc123 force-pushed the CleanupPushTest branch 3 times, most recently from a49d7a7 to ac7d830 Compare August 13, 2020 08:19
@prietyc123 prietyc123 mentioned this pull request Aug 13, 2020
Closed
@prietyc123 prietyc123 force-pushed the CleanupPushTest branch 4 times, most recently from 49ebe0a to 3ec6c98 Compare August 17, 2020 19:42
@amitkrout
Copy link
Contributor

amitkrout commented Aug 18, 2020 •
edited
Loading

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 18, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 18, 2020
@prietyc123
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link
Contributor Author

platform issue

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2020
@prietyc123
Copy link
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/3645/pull-ci-openshift-odo-master-v4.5-integration-e2e/1296139227431440384#1:build-log.txt%3A671

/retest

@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 20, 2020
@amitkrout
Copy link
Contributor

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/3645/pull-ci-openshift-odo-master-v4.5-integration-e2e/1296139227431440384#1:build-log.txt%3A671

/retest

I have created a debug pr #3792. We will get some more information on the failure.

@girishramnani
Copy link
Contributor

so adding a hold on this then
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 20, 2020
@prietyc123
Copy link
Contributor Author

prietyc123 commented Aug 21, 2020 •
edited
Loading

so adding a hold on this then

This pr is nowhere related to the issue https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/3645/pull-ci-openshift-odo-master-v4.5-integration-e2e/1296139227431440384#1:build-log.txt%3A671

It's something that is coming after 18th Aug and the main point is its not only happening on this pr only. More deatils - #3792 (comment)

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 927826e into redhat-developer:master Aug 21, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout requested changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

@mik-dass mik-dass Awaiting requested review from mik-dass

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prietyc123 @amitkrout @openshift-ci-robot @openshift-bot @girishramnani @rm3l @openshift-merge-robot