-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odo init
interactive mode: allow setting detected ports when Devfile has multiple container components
#6264
Comments
odo init
: Handle multi-containers scenario with port detection (Alizer-based or not)
…prior to asking for its customization The case of multi-container components will be handled in [1]. Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports. [1] redhat-developer#6264
…prior to asking for its customization The case of multi-container components will be handled in [1]. Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports. [1] redhat-developer#6264
…ve mode (#6365) * Do not display "Port configuration using flag is currently not supported" This is confusing to users. * Display ports detected as part of the Alizer component detection logic This is because we specifically need to display the ports at the same moment when the language, project type and Devfile are displayed to the end user (when source code is present) * Update the loaded Devfile object with the application ports detected prior to asking for its customization The case of multi-container components will be handled in [1]. Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports. [1] #6264 * Add integration test case * Add application ports detected to "odo analyze -o json" output * Update documentation * Add utility functions for helping handle Debug endpoints * Make application ports detected appear first in the endpoint list This allows such ports to be port-forwarded first, before the Debug ones.
odo init
: Handle multi-containers scenario with port detection (Alizer-based or not)odo init
: Allow specifying ports non-interactively when Devfile has multiple container components
odo init
: Allow specifying ports non-interactively when Devfile has multiple container componentsodo init
: Handle multi-containers scenario with port detection (Alizer-based or not)
odo init
: Handle multi-containers scenario with port detection (Alizer-based or not)odo init
: allow setting detected ports when Devfile has multiple container components
odo init
: allow setting detected ports when Devfile has multiple container componentsodo init
interactive mode: allow setting detected ports when Devfile has multiple container components
Grooming (2023-06-22) /priority Low Low priority - let's keep this as it is for now. |
A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity. |
This issue was closed because it has been inactive for 30 days since being marked as stale. |
/reopen Still relevant. |
@rm3l: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind user-story
User Story
As an odo user, I want to be able to set the ports detected automatically by
odo
when callingodo init
interactively even if the suggested Devfile has many container components So that I can have my Devfile initialized right away with the right ports without having to edit it later on.#5863 added the ability to automatically detect my application ports from the source code and use that as ports when initializing a Devfile interactively, but
odo
currently shows a warning if the Devfile has multiple container components:odo/pkg/init/backend/applicationports.go
Lines 33 to 39 in b481d4c
As discussed in #6211 (comment), there might be issues with Devfiles that have more than one container components.
#6919 handles the simpler case of a Devfile that has at most one container component, and the goal of this issue is to handle the case where the Devfile has more than one container component when runningodo init
interactively. #6923 will handle the case for the non-interactive mode.Acceptance Criteria
Comments
odo init
interactive mode: Automatic port detection based on Alizer detection #5863 (comment): figure out the container withmountSources
(the main container), and override ports for it. But this can have some limitationsrun
command and determine the container component it uses. This is what will is mentioned for handling the non-interactive mode:odo init
non-interactive mode: Allow specifying ports when Devfile has multiple container components #6923Links
/kind user-story
The text was updated successfully, but these errors were encountered: