Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo init interactive mode: allow setting detected ports when Devfile has multiple container components #6264

Open
1 task
rm3l opened this issue Oct 27, 2022 · 5 comments
Labels
area/init Issues or PRs related to `odo init` kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.

Comments

@rm3l
Copy link
Member

rm3l commented Oct 27, 2022

/kind user-story

User Story

As an odo user, I want to be able to set the ports detected automatically by odo when calling odo init interactively even if the suggested Devfile has many container components So that I can have my Devfile initialized right away with the right ports without having to edit it later on.

#5863 added the ability to automatically detect my application ports from the source code and use that as ports when initializing a Devfile interactively, but odo currently shows a warning if the Devfile has multiple container components:

if nbContainerComponents > 1 {
klog.V(3).Infof("found more than 1 container components in Devfile at path %q => cannot find out which component needs to be updated."+
"This case will be handled in https://github.com/redhat-developer/odo/issues/6264", devfileobj.Ctx.GetAbsPath())
fmt.Fprintln(w, "\nApplication ports detected but the current Devfile contains multiple container components. Could not determine which component to update. "+
"Please feel free to customize the Devfile configuration.")
return devfileobj, nil
}

As discussed in #6211 (comment), there might be issues with Devfiles that have more than one container components.
#6919 handles the simpler case of a Devfile that has at most one container component, and the goal of this issue is to handle the case where the Devfile has more than one container component when running odo init interactively. #6923 will handle the case for the non-interactive mode.

Acceptance Criteria

  • It should ...

Comments

Links

/kind user-story

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Oct 27, 2022
@rm3l rm3l added this to odo Project Oct 27, 2022
@rm3l rm3l added the area/init Issues or PRs related to `odo init` label Oct 27, 2022
@rm3l rm3l changed the title Handle multi-containers scenario with port detection (Alizer-based or not) odo init: Handle multi-containers scenario with port detection (Alizer-based or not) Oct 27, 2022
@rm3l rm3l added the kind/task Issue is actionable task label Oct 27, 2022
rm3l added a commit to rm3l/odo that referenced this issue Dec 1, 2022
…prior to asking for its customization

The case of multi-container components will be handled in [1].
Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports.

[1] redhat-developer#6264
rm3l added a commit to rm3l/odo that referenced this issue Dec 5, 2022
…prior to asking for its customization

The case of multi-container components will be handled in [1].
Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports.

[1] redhat-developer#6264
openshift-merge-robot pushed a commit that referenced this issue Dec 6, 2022
…ve mode (#6365)

* Do not display "Port configuration using flag is currently not supported"

This is confusing to users.

* Display ports detected as part of the Alizer component detection logic

This is because we specifically need to display the ports
at the same moment when the language, project type and Devfile
are displayed to the end user (when source code is present)

* Update the loaded Devfile object with the application ports detected prior to asking for its customization

The case of multi-container components will be handled in [1].
Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports.

[1] #6264

* Add integration test case

* Add application ports detected to "odo analyze -o json" output

* Update documentation

* Add utility functions for helping handle Debug endpoints

* Make application ports detected appear first in the endpoint list

This allows such ports to be port-forwarded first, before the Debug ones.
@rm3l rm3l changed the title odo init: Handle multi-containers scenario with port detection (Alizer-based or not) odo init: Allow specifying ports non-interactively when Devfile has multiple container components Jun 22, 2023
@rm3l rm3l changed the title odo init: Allow specifying ports non-interactively when Devfile has multiple container components odo init: Handle multi-containers scenario with port detection (Alizer-based or not) Jun 22, 2023
@rm3l rm3l changed the title odo init: Handle multi-containers scenario with port detection (Alizer-based or not) odo init: allow setting detected ports when Devfile has multiple container components Jun 22, 2023
@rm3l rm3l changed the title odo init: allow setting detected ports when Devfile has multiple container components odo init interactive mode: allow setting detected ports when Devfile has multiple container components Jun 22, 2023
@rm3l rm3l added the priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. label Jun 22, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 22, 2023

Grooming (2023-06-22)

/priority Low

Low priority - let's keep this as it is for now.

@rm3l rm3l added kind/user-story An issue of user-story kind and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. kind/task Issue is actionable task labels Jun 22, 2023
@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 22, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Oct 22, 2023
@rm3l
Copy link
Member Author

rm3l commented Oct 23, 2023

/reopen
/remove-lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen

Still relevant.

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

@rm3l: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen

Still relevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Oct 23, 2023
@openshift-ci openshift-ci bot removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to To Do 📝 in odo Project Oct 23, 2023
@openshift-ci openshift-ci bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 23, 2023
@rm3l rm3l removed the status in odo Project Oct 23, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init Issues or PRs related to `odo init` kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
Status: No status
Development

No branches or pull requests

1 participant