Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make timeout time configurable #617

Closed
jorgemoralespou opened this issue Aug 4, 2018 · 3 comments
Closed

make timeout time configurable #617

jorgemoralespou opened this issue Aug 4, 2018 · 3 comments
Assignees
Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@jorgemoralespou
Copy link
Contributor

When running odo, if the connection to the cluster is slow, it will fail with an are you authenticated error?

Timeout time needs to be configurable on:

  • global odo config file. @kadel Is this global odo config file something we should consider?
  • per command flag, as global configuration and not command specific flag

We should also revisit which commands need to check that you're connected to the cluster, as a odo app create xxx command failed on me and it shouldn't really check it.

@syamgk
Copy link
Member

syamgk commented Aug 5, 2018

we are implementing odo config command as per issue #122 so after PR #589 gets merged we can extend odo config for specifying the time-out

this is how we are implementing it now

odo config --help
Modifies Odo specific configuration settings within the config file.

Usage:
  odo config [flags]
  odo config [command]

Aliases:
  config, configuration


Examples:
  # Get the current configuration
   odo config get
 
  # Set a configuration value
   odo config set UpdateNotification false

@surajnarwade surajnarwade added kind/bug Categorizes issue or PR as related to a bug. size/M labels Sep 5, 2018
@syamgk syamgk self-assigned this Sep 12, 2018
@cdrage cdrage added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Sep 12, 2018
@syamgk
Copy link
Member

syamgk commented Sep 18, 2018

I've sent a PR #757 for this, which will allow the user to modify the default timeout value by explicitly configuring it on ~/.kube/odo file using odo utils config command

./odo utils config 
Modifies Odo specific configuration settings within the config file.

Available Parameters:
UpdateNotification - Controls if an update notification is shown or not (true or false),
Timeout            - timeout(in seconds) for openshift server connection check(1 to 99)

so, for example, the user can modify the timeout by

$ odo utils config set timeout 5

@jorgemoralespou
Copy link
Contributor Author

@kadel We need to look into the format of this file the sooner the better

syamgk added a commit to syamgk/odo that referenced this issue Oct 5, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 22, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 24, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 24, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 24, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 24, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 24, 2018
…eout

add config parameter to modify server connection check timeout
syamgk added a commit to syamgk/odo that referenced this issue Oct 29, 2018
…eout

add config parameter to modify server connection check timeout
@cdrage cdrage closed this as completed in 73173d5 Oct 30, 2018
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
@rm3l rm3l added this to odo Project Jun 18, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

No branches or pull requests

5 participants