Safely dereference volume component 'ephemeral' field

redhat-developer · Sep 8, 2023 · 261ca26 · 261ca26
1 parent 8f0f4c3
commit 261ca26
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/apiserver-impl/devstate/content.go b/pkg/apiserver-impl/devstate/content.go
@@ -8,9 +8,10 @@ import (
 	"github.com/devfile/api/v2/pkg/apis/workspaces/v1alpha2"
 	"github.com/devfile/api/v2/pkg/devfile"
 	"github.com/devfile/library/v2/pkg/devfile/parser/data/v2/common"
+	"k8s.io/utils/pointer"
+
 	. "github.com/redhat-developer/odo/pkg/apiserver-gen/go"
 	"github.com/redhat-developer/odo/pkg/libdevfile"
-	"k8s.io/utils/pointer"
 )
 
 const (
@@ -319,7 +320,7 @@ func (o *DevfileState) getVolumes() ([]Volume, error) {
 	for _, volume := range volumes {
 		result = append(result, Volume{
 			Name:      volume.Name,
-			Ephemeral: *volume.Volume.Ephemeral,
+			Ephemeral: pointer.BoolDeref(volume.Volume.Ephemeral, false),
 			Size:      volume.Volume.Size,
 		})
 	}