Fix reference to cloud_env in README and config.py #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readme and error message in config.py have references to a config option `base_env` for specifying the environment when one is not specified on the command line. The config.py code, however, looks for a config option called `cloud_env` (if I'm interpreting the code correctly). This change updates the error message and README to use the proper config option.
|
@accorvin thank you for the fix, I'm going to release this as a 0.2.0-alpha7 so the fix should be available soon. |
|
@accorvin I found that there is one minor thing - I'll add a PR fixing it and link it with yours (base it onto this branch) - the naming convention is broken with the cli. Again thank you very much, good catch. |
mijaros
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme and error message in config.py have references to a config
option
base_envfor specifying the environment when one is notspecified on the command line. The config.py code, however, looks for a
config option called
cloud_env(if I'm interpreting the codecorrectly). This change updates the error message and README to use the
proper config option.