Skip to content

Add support for prometheus metrics#12

Merged
eifrach merged 2 commits into
mainfrom
add-prometheus
Jun 23, 2025
Merged

Add support for prometheus metrics#12
eifrach merged 2 commits into
mainfrom
add-prometheus

Conversation

@natifridman

Copy link
Copy Markdown
Contributor
  • Add support for prometheus metrics
  • Split server to multiple files for readability

- Add support for prometheus metrics
- Split server to multiple files for readability
@natifridman natifridman requested a review from eifrach June 22, 2025 13:44
@maorfr

maorfr commented Jun 23, 2025

Copy link
Copy Markdown
Member

@redhat-ai-tools/jira-mcp-snowflake please review 🙏

Comment thread Containerfile Outdated
Comment on lines +10 to +14
COPY mcp_server.py ./
COPY config.py ./
COPY database.py ./
COPY tools.py ./
COPY metrics.py ./

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's organise this a bit - move everything to src folder

Suggested change
COPY mcp_server.py ./
COPY config.py ./
COPY database.py ./
COPY tools.py ./
COPY metrics.py ./
COPY ./src/ ./

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done

@eifrach eifrach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@eifrach

eifrach commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

/lgtm

@eifrach eifrach merged commit 9b6e058 into main Jun 23, 2025
2 checks passed
@eifrach eifrach deleted the add-prometheus branch June 23, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants