enterprise contract update

[ec-automation]

No description provided.

[zregvart]

/lgtm
/ok-to-test
/approve

[zregvart]

/lgtm

[zregvart]

The Task bundle will upgrade the version of EC that might cause an outage, so let's not merge this until we have a fix for it.

[lcarva]

Removed the problematic parts. Moving it out of draft so we can get a hotfix in for ec-policies.

[lcarva]

/lgtm

[zregvart]

Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ec-automation[bot], zregvart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• components/enterprise-contract/OWNERS [zregvart]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zregvart]

/lgtm

[lcarva]

Things are broken:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/4707/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1846116860576141312/artifacts/appstudio-e2e-tests/gather-extra/artifacts/pods/chains-e2e-itpu-tenant_verify-enterprise-contract-f39549e2defe46e46a0c74659aef7118-pod_step-validate.log

Error: error validating image quay.io/konflux-ci/ec-golden-image@sha256:d9e2e0b8982dfbda98f59f1fab88795edc84a754a46bd4cce0693701dfda1adf of component -sha256:d9e2e0b8982dfbda98f59f1fab88795edc84a754a46bd4cce0693701dfda1adf-arm64: load: loading policies: get compiler: 11 errors occurred:
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/lib/time/time_test.rego:1: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/lib/time/time_test.rego:1
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/attestation_task_bundle.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/attestation_task_bundle.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/attestation_type.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/attestation_type.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/base_image_registries.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/base_image_registries.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/buildah_build_task.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/buildah_build_task.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/github.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/github.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/minimal.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/minimal.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/policy_data.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/policy_data.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/redhat.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/redhat.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/rhtap_jenkins.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/rhtap_jenkins.rego:2
rego_compile_error: error limit reached

[joejstuart]

Things are broken:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/4707/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1846116860576141312/artifacts/appstudio-e2e-tests/gather-extra/artifacts/pods/chains-e2e-itpu-tenant_verify-enterprise-contract-f39549e2defe46e46a0c74659aef7118-pod_step-validate.log

Error: error validating image quay.io/konflux-ci/ec-golden-image@sha256:d9e2e0b8982dfbda98f59f1fab88795edc84a754a46bd4cce0693701dfda1adf of component -sha256:d9e2e0b8982dfbda98f59f1fab88795edc84a754a46bd4cce0693701dfda1adf-arm64: load: loading policies: get compiler: 11 errors occurred:
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/lib/time/time_test.rego:1: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/lib/time/time_test.rego:1
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/attestation_task_bundle.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/attestation_task_bundle.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/attestation_type.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/attestation_type.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/base_image_registries.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/base_image_registries.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/buildah_build_task.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/buildah_build_task.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/github.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/github.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/minimal.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/minimal.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/policy_data.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/policy_data.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/redhat.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/redhat.rego:2
/tmp/ec-work-502570160/policy/bc5c1d19d/policy/release/collection/rhtap_jenkins.rego:2: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/release/collection/rhtap_jenkins.rego:2
rego_compile_error: error limit reached

I'm wondering if this is the caching issue. There's multiple directories after policy/tmp/ec-work-502570160/policy/bc5c1d19d/policy/lib/time/time_test.rego:1: rego_type_error: package annotation redeclared: /tmp/ec-work-502570160/policy/29d85ef11/policy/lib/time/time_test.rego:1

[zregvart]

Looks exactly like the issue we did the rollback for in konflux-ci/build-definitions#1510, not sure how is that still present here without the EC CLI update

[lcarva]

It looks like the errors I found were from a previous run. The IDs in the URLs are different. It looks like it failed due to some sort of infra issue

[lcarva]

/retest-required

[zregvart]

Looks exactly like the issue we did the rollback for in konflux-ci/build-definitions#1510, not sure how is that still present here without the EC CLI update

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/4707/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1846116860576141312/artifacts/appstudio-e2e-tests/gather-extra/artifacts/pods/chains-e2e-itpu-tenant_verify-enterprise-contract-f39549e2defe46e46a0c74659aef7118-pod_step-version.log

Shows unexpected version of EC (for me), it is too new, and contains the issue we rolled back the update in build definitions for.

[zregvart]

It looks like the errors I found were from a previous run. The IDs in the URLs are different. It looks like it failed due to some sort of infra issue

🤞

[zregvart]

/lgtm

[zregvart]

/retest-required

[openshift-ci]

@ec-automation[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/appstudio-upgrade-tests	4a8788f	link	false	/test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zregvart]

/lgtm