Skip to content

fix: image-contoller and build-service overlay changes for refactoring dev/stage and prod #2988

Merged
openshift-merge-bot[bot] merged 3 commits into
redhat-appstudio:mainfrom
tisutisu:layout-break
Jan 10, 2024
Merged

fix: image-contoller and build-service overlay changes for refactoring dev/stage and prod #2988
openshift-merge-bot[bot] merged 3 commits into
redhat-appstudio:mainfrom
tisutisu:layout-break

Conversation

@tisutisu
Copy link
Copy Markdown
Member

@tisutisu tisutisu commented Jan 2, 2024 •
edited
Loading

The changes are part of story: https://issues.redhat.com/browse/STONEBLD-1924

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the approved label Jan 2, 2024
@tisutisu
Copy link
Copy Markdown
Member Author

tisutisu commented Jan 2, 2024

/test all

@tisutisu tisutisu marked this pull request as ready for review January 5, 2024 10:09
@openshift-ci openshift-ci Bot requested review from mmorhun and rcerven January 5, 2024 10:09
@tisutisu tisutisu requested a review from chmeliik January 5, 2024 11:04
chmeliik
chmeliik reviewed Jan 5, 2024
View reviewed changes
Comment thread components/build-service/development/kustomization.yaml Outdated
Comment thread components/build-service/development/kustomization.yaml Outdated
Comment thread components/build-service/staging/base/kustomization.yaml Outdated
Comment thread components/image-controller/development/kustomization.yaml Outdated
chmeliik
chmeliik approved these changes Jan 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nitpicks 👍

Comment thread .tekton/tasks/promote-component.yaml Outdated
Comment thread .tekton/tasks/promote-component.yaml Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, tisutisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tisutisu
Copy link
Copy Markdown
Member Author

tisutisu commented Jan 8, 2024

/test appstudio-e2e-tests

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 10, 2024

@tisutisu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 6704c4d link false /test appstudio-hac-e2e-tests
ci/prow/appstudio-upgrade-tests 6704c4d link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chmeliik
Copy link
Copy Markdown
Member

chmeliik commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jan 10, 2024
mmorhun
mmorhun reviewed Jan 10, 2024
View reviewed changes
Comment thread .tekton/build-service-prod-overlay-update.yaml
Comment thread components/build-service/staging/base/kustomization.yaml
newTag: 45e8fe7c3b036d1df3eee11c1d83e0633e451c07

commonAnnotations:
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true No newline at end of file
Copy link
Copy Markdown
Member

@mmorhun mmorhun Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Copy Markdown
Member Author

@tisutisu tisutisu Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr got merged now.. will address this in a future PR

Comment thread components/image-controller/staging/kustomization.yaml
namespace: image-controller

patches:
- path: ./manager_resources_patch.yaml No newline at end of file
Copy link
Copy Markdown
Member

@mmorhun mmorhun Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Copy Markdown
Member Author

@tisutisu tisutisu Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr got merged now.. will address this in a future PR

@tisutisu tisutisu mentioned this pull request Jan 10, 2024
Merged
@openshift-merge-bot openshift-merge-bot Bot merged commit 1cf8090 into redhat-appstudio:main Jan 10, 2024
@tisutisu tisutisu mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcerven rcerven Awaiting requested review from rcerven

2 more reviewers

@mmorhun mmorhun mmorhun left review comments

@chmeliik chmeliik chmeliik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chmeliik chmeliik

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tisutisu @chmeliik @mmorhun @openshift-merge-robot