Repository navigation
fix(dashboard): request details render any content shape; account order saved atomically - #80
Merged
Merged
Conversation
…er saved atomically - The request-details view rendered response.content/thinking straight into a <pre>, crashing on an array of content blocks (PentatonicDev cb937dd). safeText() renders strings as-is and anything else as JSON. - Reordering accounts wrote two 0-based priorities in parallel (last write won; upstream decolua#4280), and indexed the full list with positions from the owner-filtered one, so the wrong rows moved when a filter was on. The UI now swaps within the list on screen and saves it once through PUT /api/providers/reorder, which fills the visible accounts' own slots (hidden ones keep theirs), writes 1..N in one transaction (setConnectionOrder), and keeps shared accounts admin-managed. - reorderInTx read a missing/0 priority as first while getProviderConnections read it as last; both now read it as last.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 4 of the plan from the review of
decolua/9routerandPentatonicDev/9router.What
response.contentandthinkingwere rendered straight into a<pre>, which crashed on an array of content blocks.safeText()(src/shared/utils/safeText.js) renders strings as-is and anything else as JSON.PUT /api/providers/reorder. That route:setConnectionOrder);reorderInTxread a missing or 0 priority as first, whilegetProviderConnectionsread it as last. Both now read it as last.Dropped from the plan: the usage-by-key grouping item. It was fixed, more thoroughly, in #77: opaque keys, no raw keys in any period.
Tests
dashboard-fixes.test.js:safeText;setConnectionOrder(explicit order, unlisted accounts kept in place, unknown ids ignored);db-sqlite-vs-lowdb.test.jsandrequest-details-tab.test.jspass unchanged.--maxWorkers=2: 364 files passed, 0 failures.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.