NFSv4.x: Fix a refcount leak in nfs_callback_up_net

On error, the callers expect us to return without bumping nn->cb_users[]. Signed-off-by: Trond Myklebust <[email protected]> Cc: [email protected] # v3.7+
redbrain17 · Aug 30, 2016 · 98b0f80 · 98b0f80
1 parent 52442f9
commit 98b0f80
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
@@ -275,6 +275,7 @@ static int nfs_callback_up_net(int minorversion, struct svc_serv *serv,
 err_socks:
 	svc_rpcb_cleanup(serv, net);
 err_bind:
+	nn->cb_users[minorversion]--;
 	dprintk("NFS: Couldn't create callback socket: err = %d; "
 			"net = %p\n", ret, net);
 	return ret;