ext4: return -ENOMEM instead of success

We should set the error code if kzalloc() fails. Fixes: 67cf5b0 ("ext4: add the basic function for inline data support") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Theodore Ts'o <[email protected]> Cc: [email protected]
redbrain17 · Dec 10, 2016 · 578620f · 578620f
1 parent 7e6e1ef
commit 578620f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
@@ -341,8 +341,10 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode,
 
 	len -= EXT4_MIN_INLINE_DATA_SIZE;
 	value = kzalloc(len, GFP_NOFS);
-	if (!value)
+	if (!value) {
+		error = -ENOMEM;
 		goto out;
+	}
 
 	error = ext4_xattr_ibody_get(inode, i.name_index, i.name,
 				     value, len);