Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites with parenthesis fail to rename without warning #290

Closed
edwardrowe opened this issue Feb 17, 2022 · 1 comment
Closed

Sprites with parenthesis fail to rename without warning #290

edwardrowe opened this issue Feb 17, 2022 · 1 comment
Labels
bug fixed in development The issue is fixed in the development branch

Comments

@edwardrowe
Copy link
Contributor

Report: https://forum.unity.com/threads/mulligan-renamer.532182/#post-7880896

Repro:

  1. Create a spritesheet with a Sprite with a name that includes parenthesis. Ex: "Sprite_Jump(0)"
  2. Add it to Bulk Renamer
  3. Add a rule so to rename part of it. Ex: "Sprite" -> "Pic"
  4. Rename
  5. Notice the Sprite is not renamed

The issue is the regex to find these characters in the renamer. Since it doesn't escape the original name, it will fail to replace it in the meta as it won't be able to find it with the invalid regex as the old name.

The fix is to escape the original name.

@edwardrowe edwardrowe added the bug label Feb 17, 2022
@edwardrowe
Copy link
Contributor Author

edwardrowe commented Feb 17, 2022

All special characters that we ban on Assets are actually allowed on Sprites. We can go ahead and remove all characters from the invalid list for Sprites.

@edwardrowe edwardrowe added the fixed in development The issue is fixed in the development branch label Feb 17, 2022
edwardrowe added a commit that referenced this issue Feb 17, 2022
Remove invalid character restrictions for Sprites (Fixes #290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed in development The issue is fixed in the development branch
Projects
None yet
Development

No branches or pull requests

1 participant