Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot rename assets containing a dot character #282

Closed
dorba opened this issue Jul 16, 2021 · 3 comments
Closed

Cannot rename assets containing a dot character #282

dorba opened this issue Jul 16, 2021 · 3 comments

Comments

@dorba
Copy link

dorba commented Jul 16, 2021

I'm just noting this in case it's something you'd like to modify.

When renaming, the dot character is included in the list of invalid characters, preventing those assets from being renamed. I'm not sure if this restriction existed in previous versions, but 2020 LTS will accept dots in the asset name.

I was able to fix locally by removing the character from the array here:
https://github.com/redbluegames/unity-mulligan-renamer/blob/main/Assets/RedBlueGames/MulliganRenamer/Editor/Renaming/RenamePreview.cs#L112

@edwardrowe
Copy link
Contributor

edwardrowe commented Jul 17, 2021 via email

edwardrowe added a commit that referenced this issue Jul 18, 2021
This is actually a valid character name, at least in 2019, so I'm just
going to allow it for all versions. User beware (assuming it was actually
ever an illegal character at all).
@edwardrowe
Copy link
Contributor

Thanks again. Should be fixed in Main, though I haven't cut a release for the AssetStore and I don't think I will because it's a pain. If you're using the AssetStore version let me know, and I'll get an updated version out.

@edwardrowe
Copy link
Contributor

Release as a .unitypackage is here if you'd like it: https://github.com/redbluegames/unity-mulligan-renamer/releases/tag/v1.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants