-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot rename assets containing a dot character #282
Comments
Thanks for the report - I don't regularly work on the newer versions so
it's really helpful to have people looking out for issues.
I'll get some time to check this one out this weekend hopefully.
Thanks!
…On Fri, Jul 16, 2021, 5:48 PM Barry Dorman ***@***.***> wrote:
I'm just noting this in case it's something you'd like to modify.
When renaming, the dot character is included in the list of invalid
characters, preventing those assets from being renamed. I'm not sure if
this restriction existed in previous versions, but 2020 LTS will accept
dots in the asset name.
I was able to fix locally by removing the character from the array here:
https://github.com/redbluegames/unity-mulligan-renamer/blob/main/Assets/RedBlueGames/MulliganRenamer/Editor/Renaming/RenamePreview.cs#L112
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#282>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADBIKMG7VTU2GNLNVLHNKDTYCSLFANCNFSM5AQKHM2Q>
.
|
edwardrowe
added a commit
that referenced
this issue
Jul 18, 2021
This is actually a valid character name, at least in 2019, so I'm just going to allow it for all versions. User beware (assuming it was actually ever an illegal character at all).
Thanks again. Should be fixed in Main, though I haven't cut a release for the AssetStore and I don't think I will because it's a pain. If you're using the AssetStore version let me know, and I'll get an updated version out. |
Release as a .unitypackage is here if you'd like it: https://github.com/redbluegames/unity-mulligan-renamer/releases/tag/v1.7.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm just noting this in case it's something you'd like to modify.
When renaming, the dot character is included in the list of invalid characters, preventing those assets from being renamed. I'm not sure if this restriction existed in previous versions, but 2020 LTS will accept dots in the asset name.
I was able to fix locally by removing the character from the array here:
https://github.com/redbluegames/unity-mulligan-renamer/blob/main/Assets/RedBlueGames/MulliganRenamer/Editor/Renaming/RenamePreview.cs#L112
The text was updated successfully, but these errors were encountered: