Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception: Current Language Not Set on Upgrade #252

Closed
edwardrowe opened this issue May 12, 2020 · 2 comments
Closed

Exception: Current Language Not Set on Upgrade #252

edwardrowe opened this issue May 12, 2020 · 2 comments
Labels
bug

Comments

@edwardrowe
Copy link
Contributor

Little_Gorilla reported that on an update to 2019.2 they received Exception: Current Language Not Set:

https://forum.unity.com/threads/mulligan-renamer.532182/#post-5808151
@edwardrowe edwardrowe added the bug label May 12, 2020
edwardrowe added a commit that referenced this issue May 12, 2020
@edwardrowe
Fixes Issue #252 where languages were null when updating
998b2fa 
When updating with the MulliganRenamer window open, Resources failed
to load on the first frame. This meant languages were null and
requesting a translation failed to find anything.

This fix continues to load resources until they are loaded.
edwardrowe added a commit that referenced this issue May 12, 2020
@edwardrowe
Merge pull request #254 from redbluegames/252-language-not-set
14170a3 
Fix for #252 and #251
@edwardrowe edwardrowe mentioned this issue May 13, 2020
Merged
@edwardrowe
Copy link
Contributor Author

Fixed this by having LocalizationManager return empty strings until Languages have successfully loaded from Resources.

@edwardrowe
Copy link
Contributor Author

Fixed in release v1.7.2. Store update to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edwardrowe