Can't see deleted spaces in the Diff

[edwardrowe]

It's hard to know when spaces are deleted because they aren't marked in the diff (can't color a space red).

To fix this, we'd need to do an improved diffing view that colored the background, similar to Sublime Text's find and replace (which looks awesome).

[Mukarillo]

Hey @edwardrowe,

I am not so sure how you imagine this working, but I tried to replicate the Sublime Text's find and replace, here is it:

The first file is called "_[]b[][][]a" and the second "a[][]b", being [] whitespaces

It is like this that you were imagining this feature?

[edwardrowe]

It's very helpful to have another pair of eyes on this. I used SublimeText as reference too, so it's good to hear that's where you're looking. I do like the background highlight in SublimeText, but found it hard to replicate. Is that what you were going for here? This is hard to do I think within Unity, but I was hoping it would highlight only the spaces. What do you think about that? Here's a mockup: [image: image.png]

…

On Sun, Oct 13, 2019 at 3:28 PM Murillo Pugliesi Lopes < ***@***.***> wrote: Hey @edwardrowe <https://github.com/edwardrowe>, I am not so sure how you imagine this working, but I tried to replicate the Sublime Text's find and replace, here is it: [image: Example] <https://camo.githubusercontent.com/d485185053cff990eaa5b8e295f3f77d49df99dd/68747470733a2f2f692e696d6775722e636f6d2f4f356a59566a6f2e706e67> The first file is called "_[]b[][][]a" and the second "a[][]b", being [] whitespaces It is like this that you were imagining this feature? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160?email_source=notifications&email_token=AADBIKIWUJB7DM75B2LYBP3QONZHLA5CNFSM4E2NZ2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBC56BY#issuecomment-541449991>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBIKK7EJMGKP2TH7IBVLLQONZHLANCNFSM4E2NZ2TA> .

[Mukarillo]

I am sorry, but I can't see the attachment.
Do you mind uploading the image somewhere else and posting the link here?

[edwardrowe]

Does this work? I did that via email, must not have liked it.

I'm removing "space" characters as well as 'm', 'a', and 'c', just for comparison.

[Mukarillo]

Oh, now I see, thanks!
I think I can replicate this with a bit of creativity. Let me try something.

[Mukarillo]

Hey @edwardrowe,

I think I got it working the way you imagined it

Was that how you thought it would work?

[edwardrowe]

Yes, it looks like I envisioned, and I think your style measurement method, to measure the areas with style.CalcSize seems solid. Again I'll have to give you some thorough time for review later this week or next. But thank you very much in the meantime. I don't think I'd have tackled this for a long time but it's a really big value add!

…

On Mon, Oct 14, 2019 at 2:50 AM Murillo Pugliesi Lopes < ***@***.***> wrote: Hey @edwardrowe <https://github.com/edwardrowe>, I think I got it working the way you imagined it [image: Example] <https://camo.githubusercontent.com/c8533968088ba77146e5e8436540f5e0b4452589/68747470733a2f2f692e696d6775722e636f6d2f386730324c6c582e676966> Was that how you thought it would work? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160?email_source=notifications&email_token=AADBIKPXQJ6M7RHZBMISXETQOQJDXA5CNFSM4E2NZ2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBDPULA#issuecomment-541522476>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBIKNLK2UMQS3ISWVKYJLQOQJDXANCNFSM4E2NZ2TA> .

[Mukarillo]

No problem at all @edwardrowe, take your time.
I am glad that I am adding value to this project :)