Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented themable color ranges for heatmap and X/Y #133

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

andy-lee-eng
Copy link
Collaborator

Implemented a special interpolator to connect up multiple two-color interpolators
Heatmap color has to be reapplied because the d3fc one forces it to the data extent rather than the color range you've given it
Found some d3 color utility functions

Implemented a special interpolator to connect up multiple two-color interpolators
Heatmap color has to be reapplied because the d3fc one forces it to the data extent rather than the color range you've given it
Found some d3 color utility functions
Copy link
Collaborator

@matt-hooper matt-hooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small thing. For the following heatmap which has a date based cross axis we seem to get an extra line going through each box:
http://localhost:3000/finance/finance.heatmap1.html

image

It may have already been there, but it is more obvious now with the new colours.

@andy-lee-eng
Copy link
Collaborator Author

I think we should raise the gridline thing as a separate issue. It may mean we need to drop the gridlines component from heatmap charts, though that might not work so well on very sparse charts. Otherwise, we'll need to find some way to offset the gridline somehow?

@matt-hooper
Copy link
Collaborator

I think we should raise the gridline thing as a separate issue. It may mean we need to drop the gridlines component from heatmap charts, though that might not work so well on very sparse charts. Otherwise, we'll need to find some way to offset the gridline somehow?

I have raised a new JIRA: https://int.scottlogic.co.uk/jira/browse/IPJS-88
I am therefore happy to approve this PR.

@andy-lee-eng andy-lee-eng merged commit 83251e2 into develop Mar 28, 2019
@andy-lee-eng andy-lee-eng deleted the feature/themable-heatmap branch March 28, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants