Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes HockeyApp use #635

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removes HockeyApp use #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b001484
removes HockeyApp use
markholland Dec 13, 2018
3a20186
Clearer examples
markholland Dec 18, 2018
ba4af65
Merge branch 'master' into remove-hockeyapp
markholland Dec 18, 2018
2c526ef
reverts plugin update
markholland Dec 20, 2018
a8ab13d
Merge branch 'remove-hockeyapp' of github.com:redbadger/pride-london-…
markholland Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ jobs:
bundle exec fastlane alpha \
submit:true \
apk_path:$APK_PATH \
api_token:$HOCKEY_APP_TOKEN \
app_id:$HOCKEY_APP_ANDROID_ALPHA_APP_ID \
fabric_api_token:$FABRIC_API_KEY \
fabric_build_secret:$FABRIC_BUILD_SECRET \
fabric_groups:$FABRIC_GROUPS \
Expand Down Expand Up @@ -310,8 +308,6 @@ jobs:
bundle exec fastlane beta \
submit:true \
apk_path:$APK_PATH \
api_token:$HOCKEY_APP_TOKEN \
app_id:$HOCKEY_APP_ANDROID_BETA_APP_ID \
fabric_api_token:$FABRIC_API_KEY \
fabric_build_secret:$FABRIC_BUILD_SECRET \
fabric_groups:$FABRIC_GROUPS \
Expand Down Expand Up @@ -373,8 +369,6 @@ jobs:
command: |
bundle exec fastlane alpha \
submit:true \
api_token:$HOCKEY_APP_TOKEN \
app_id:$HOCKEY_APP_IOS_ALPHA_APP_ID \
fabric_api_token:$FABRIC_API_KEY \
fabric_build_secret:$FABRIC_BUILD_SECRET \
fabric_groups:$FABRIC_GROUPS \
Expand Down Expand Up @@ -408,8 +402,6 @@ jobs:
command: |
bundle exec fastlane beta \
submit:true \
api_token:$HOCKEY_APP_TOKEN \
app_id:$HOCKEY_APP_IOS_BETA_APP_ID \
fabric_api_token:$FABRIC_API_KEY \
fabric_build_secret:$FABRIC_BUILD_SECRET \
fabric_groups:$FABRIC_GROUPS \
Expand Down
31 changes: 0 additions & 31 deletions android/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@ platform :android do
groups: options[:fabric_groups],
notify: false,
)
deploy_hockey(
commit_sha: options[:commit_sha],
api_token: options[:api_token],
app_id: options[:app_id],
apk_path: options[:apk_path],
status: "2",
notify: "0",
notes: notes,
)
end
end

Expand All @@ -66,15 +57,6 @@ platform :android do
groups: options[:fabric_groups],
notify: true,
)
deploy_hockey(
commit_sha: options[:commit_sha],
api_token: options[:api_token],
app_id: options[:app_id],
apk_path: options[:apk_path],
status: "2",
notify: "1",
notes: notes,
)
end
end

Expand All @@ -93,19 +75,6 @@ platform :android do
end
end

desc "Deploy to HockeyApp"
lane :deploy_hockey do |options|
hockey(
api_token: options[:api_token],
public_identifier: options[:app_id],
apk: options[:apk_path],
notes: options[:notes],
status: options[:status],
notify: options[:notify],
commit_sha: options[:commit_sha]
)
end

desc "Deploy to Beta by Fabric"
lane :deploy_fabric do |options|
File.write("./notes.txt", options[:notes])
Expand Down
8 changes: 0 additions & 8 deletions android/fastlane/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@ fastlane android release

Build and deploy to Play Store

### android deploy_hockey

```
fastlane android deploy_hockey
```

Deploy to HockeyApp

### android deploy_fabric

```
Expand Down
5 changes: 1 addition & 4 deletions ios/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ GEM
fastlane-plugin-bugsnag (1.3.2)
git
xml-simple
fastlane-plugin-get_unprovisioned_devices_from_hockey (0.1.1)
json
gh_inspector (1.1.3)
git (1.3.0)
git (1.5.0)
google-api-client (0.23.9)
addressable (~> 2.5, >= 2.5.1)
googleauth (>= 0.5, < 0.7.0)
Expand Down Expand Up @@ -162,7 +160,6 @@ PLATFORMS
DEPENDENCIES
fastlane
fastlane-plugin-bugsnag
fastlane-plugin-get_unprovisioned_devices_from_hockey

BUNDLED WITH
1.16.2
34 changes: 4 additions & 30 deletions ios/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ platform :ios do
groups: options[:fabric_groups],
notify: false,
)
deploy_hockey(
commit_sha: options[:commit_sha],
api_token: options[:api_token],
app_id: options[:app_id],
status: "2",
notify: "0",
notes: notes
)
end
end

Expand All @@ -77,14 +69,6 @@ platform :ios do
groups: options[:fabric_groups],
notify: true,
)
deploy_hockey(
commit_sha: options[:commit_sha],
api_token: options[:api_token],
app_id: options[:app_id],
status: "2",
notify: "1",
notes: notes,
)
upload_symbols_to_bugsnag
send_build_to_bugsnag(
api_key: options[:bugsnag_api_key],
Expand Down Expand Up @@ -145,18 +129,6 @@ platform :ios do
)
end

desc "Upload to HockeyApp"
lane :deploy_hockey do |options|
hockey(
api_token: options[:api_token],
public_identifier: options[:app_id],
notes: options[:notes],
status: options[:status],
notify: options[:notify],
commit_sha: options[:commit_sha]
)
end

desc "Upload to Beta by Fabric"
lane :deploy_fabric do |options|
crashlytics(
Expand Down Expand Up @@ -199,8 +171,10 @@ platform :ios do

desc "Add devices"
lane :devices do |options|
new_devices = get_unprovisioned_devices_from_hockey(app_bundle_id:'org.prideinlondon.festival', api_token:options[:api_token])
register_devices(devices: new_devices)
devices = {
# "Example device name" => "1234567890ABCD",
}
register_devices(devices: devices)
match(
type: "development",
app_identifier: "org.prideinlondon.festival",
Expand Down
1 change: 0 additions & 1 deletion ios/fastlane/Pluginfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
#
# Ensure this file is checked in to source control!

gem 'fastlane-plugin-get_unprovisioned_devices_from_hockey'
gem 'fastlane-plugin-bugsnag'
8 changes: 0 additions & 8 deletions ios/fastlane/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,6 @@ fastlane ios deploy_testflight

Upload to TestFlight and notify testers

### ios deploy_hockey

```
fastlane ios deploy_hockey
```

Upload to HockeyApp

### ios deploy_fabric

```
Expand Down