Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease font size of CategoryPill #581

Closed
wants to merge 1 commit into from

Conversation

RGBboy
Copy link
Contributor

@RGBboy RGBboy commented Jul 5, 2018

Fixes #155. Make category pill text size slightly smaller so we can have more on a single line on the event details screen.

Note: This will also affect the filter screen pill size when categories are selected and the home screen category labels over each event. It would be good to get UXD input here if that is ok.

I have looked into the contrast ratios of the pills and I think we may have misunderstood reaching AA standard. The table below outlines the standard that the combination of background and foreground color currently produces. Of note are the ones that only reach AA Large standard. This means that we should only be using this combo when the font size is 24 px or larger. The Current size of font for Category pills is 16 and with this change, reduces it to 15. Interestingly if we change the foreground color to black we reach the AA standard which allows any font size.

Label Background Foreground Accessibility Standard If Foreground Black
Cabaret and Variety Coral White AA Large AA
Community Bright Light Blue Black AAA -
Talks and Debates Dark Sky Blue White AA Large AA
Film and Screenings Light Teal Black AAA -
Plays and Theatre Warm Pink White AA Large AA
Social and Networking Turquoise Blue Black AA -
Nightlife Yellow Color Black AAA -
Exhibition and Tours Bright Purple White AA AA
Sports and Activities Vomit Yellow Black AAA -
Health Bubblegum Pink Black AAA -
Music Cornflower Blue White AA AA

@RGBboy RGBboy changed the title decrease font size of CategoryPill; decrease font size of CategoryPill Jul 5, 2018
Copy link

@Lily418 Lily418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have discussed this with @RGBboy some concerns over contrast becoming an issue at this lower font size. Also these tags are buttons so the hitbox size is also lowered by this change.

@Lily418
Copy link

Lily418 commented Jul 5, 2018

screen shot 2018-07-05 at 11 20 13

@RGBboy
Copy link
Contributor Author

RGBboy commented Jul 5, 2018

Blocking for now until #582 is resolved

@RGBboy
Copy link
Contributor Author

RGBboy commented Jul 6, 2018

We have decided not to decrease the font size due to the accessibility implications.

@RGBboy RGBboy closed this Jul 6, 2018
@RGBboy RGBboy deleted the gh-155-decrease-category-pill-font-size branch July 6, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants