Create ClusterRoleBinding to fetch in-cluster monitoring metrics

[ezio-auditore]

Fixes

• https://issues.redhat.com/browse/DFBUGS-224
• https://issues.redhat.com/browse/DFBUGS-370

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[leelavg]

why should an operator create ClusterRoleBinding as that's the role of olm/admin?

[ezio-auditore]

why should an operator create ClusterRoleBinding as that's the role of olm/admin?

@leelavg this is required only on ROSA HCP platforms and k8s service monitor needs this cluster rolebinding according to the namespace the user deploys it in.

[leelavg]

why should an operator create ClusterRoleBinding as that's the role of olm/admin?

@leelavg this is required only on ROSA HCP platforms and k8s service monitor needs this cluster rolebinding according to the namespace the user deploys it in.

• there is a discrepancy here, isn't it? yaml says openshift-storage and code says whichever ns the operator is displayed which mostly is different in ROSA
• does ocs-op already have RBAC to create CRB?

doesn't olm already update the namespace in CRB if that's part of the bundle?

[ezio-auditore]

why should an operator create ClusterRoleBinding as that's the role of olm/admin?

@leelavg this is required only on ROSA HCP platforms and k8s service monitor needs this cluster rolebinding according to the namespace the user deploys it in.

• there is a discrepancy here, isn't it? yaml says openshift-storage and code says whichever ns the operator is displayed which mostly is different in ROSA
• does ocs-op already have RBAC to create CRB?

doesn't olm already update the namespace in CRB if that's part of the bundle?

@leelavg
I did check and yes OLM updates CRB if part of the bundle. It already does this for ocs-operator,ux-backend-server
I can just add a CRB for prometheus-k8s SA to have cluster-monitoring-view . Any reconcile actions will not be required.

[umangachapagain]

This is not the right file to add custom RBACs. These will be removed when we update generated content.
Add this CRB to ocs-operator/rbac directory.

Then run make update-generated and make gen-latest-csv to update the operator bundle.

[ezio-auditore]

Done

[umangachapagain]

Suggested change

namespace: openshift-storage

It can be dropped as we expect OLM to fill it based on namespace where operator gets deployed.

[ezio-auditore]

Dropped

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ezio-auditore
Once this PR has been reviewed and has the lgtm label, please ask for approval from umangachapagain. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ezio-auditore]

/test ocs-operator-bundle-e2e-aws

[ezio-auditore]

/test ocs-operator-bundle-e2e-aws

[openshift-ci]

@ezio-auditore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocs-operator-bundle-e2e-aws	325f457	link	true	/test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.