Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2135632: [release-4.10] Don't use rook master tag in Job #1858

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1854

/assign subhamkrai

we should not be using rook master tag in init container in product
deployments instead, we should be using rook version from env var.

Signed-off-by: subhamkrai <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: subhamkrai.

Note that only red-hat-storage members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #1854

/assign subhamkrai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit agarwal-mudit changed the title [release-4.10] Don't use rook master tag in Job Bug 2135632: [release-4.10] Don't use rook master tag in Job Oct 19, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2135632, which is invalid:

  • expected the bug to target the "ODF 4.10.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2135632: [release-4.10] Don't use rook master tag in Job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 19, 2022
@subhamkrai
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

@subhamkrai: This pull request references Bugzilla bug 2135632, which is invalid:

  • expected the bug to target the "ODF 4.10.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 19, 2022
@subhamkrai
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@subhamkrai: This pull request references Bugzilla bug 2135632, which is invalid:

  • expected the bug to target the "ODF 4.10.9" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@subhamkrai: This pull request references Bugzilla bug 2135632, which is invalid:

  • expected the bug to target the "ODF 4.10.9" release, but it targets "ODF 4.10.10" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link
Contributor

@subhamkrai: This pull request references Bugzilla bug 2135632, which is invalid:

  • expected the bug to target the "ODF 4.10.9" release, but it targets "ODF 4.10.10" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

@sunilheggodu we need to update the bot?

@subhamkrai
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@subhamkrai: This pull request references Bugzilla bug 2135632, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.10) matches configured target release for branch (ODF 4.10.10)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunilheggodu
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2022
@sunilheggodu
Copy link

/approve

@sunilheggodu
Copy link

/cc travisn

@openshift-ci openshift-ci bot requested a review from travisn December 17, 2022 04:26
@travisn
Copy link
Contributor

travisn commented Dec 19, 2022

/lgtm

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@iamniting iamniting added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: iamniting, openshift-cherrypick-robot, sunilheggodu, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 488ab8b link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamniting
Copy link
Member

/override /test ocs-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@iamniting: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /test
  • ocs-operator-bundle-e2e-aws

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-ocs-operator-bundle
  • ci/prow/images
  • ci/prow/ocs-operator-bundle-e2e-aws
  • ci/prow/ocs-operator-ci
  • ci/prow/red-hat-storage-ocs-ci-e2e-aws
  • ci/prow/verify-latest-csv
  • pull-ci-red-hat-storage-ocs-operator-main-ci-index-ocs-operator-bundle
  • pull-ci-red-hat-storage-ocs-operator-main-images
  • pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws
  • pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-ci
  • pull-ci-red-hat-storage-ocs-operator-main-red-hat-storage-ocs-ci-e2e-aws
  • pull-ci-red-hat-storage-ocs-operator-main-verify-latest-csv
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override /test ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/override ci/prow/ocs-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ocs-operator-bundle-e2e-aws

In response to this:

/override ci/prow/ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e071718 into red-hat-storage:release-4.10 Dec 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2135632 has been moved to the MODIFIED state.

In response to this:

Bug 2135632: [release-4.10] Don't use rook master tag in Job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants