Repository navigation
[RHOAI 3.5] fix: trainer image tag odh-3.5.0 + progression e2e races - #141
Merged
Merged
Conversation
The "metrics endpoint unreachable" test had two race conditions: 1. The Consistently block checking running status could race with job completion and annotation synthesis between status check and assertion 2. The final assertion expected no annotation, but raced with the reconciler's fallback that synthesizes 100% on completion Test was passing for 8 months probably because the race condition never got hit - the check that no annotation was added was done quickly, probably before the final reconcile happened. Fix: Remove flaky assertions about annotation state. Focus on what matters - the controller handles metrics errors gracefully and the TrainJob completes successfully Signed-off-by: Rob Bell <robell@redhat.com>
Konflux release-push publishes quay.io/opendatahub/trainer:odh-3.5.0, but params.env referenced the non-existent odh-3.5 stream tag, causing operator RHOAI e2e ImagePullBackOff (RHOAIENG-80313). Leave TH image tags on odh-3.5 where those Quay tags already exist. Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 31027195448Coverage remained the same at 53.898%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Satisfy pre-commit end-of-file-fixer on the RHOAI 3.5 cherry-pick. Co-authored-by: Cursor <cursoragent@cursor.com>
kapil27
changed the title
ChughShilpa
self-requested a review
August 6, 2026 06:18
kapil27
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick midstream fixes needed for ODH/RHOAI operator e2e (
RHOAIENG-80313):f5ffd6de) — remove race conditions in progression tracking E2E test (Rob Bell)896c93c6) — point trainer controller image atodh-3.5.0to match Konflux release-push / QuayWhy
quay.io/opendatahub/trainer:odh-3.5(manifest unknown).odh-3.5.0only;params.envstill referencedodh-3.5.red-hat-data-services/trainer:rhoai-3.5, so midstream-only is not enough.TH image tags remain on
:odh-3.5(those Quay tags exist).Test plan
manifests/rhoai/params.envcontroller image isquay.io/opendatahub/trainer:odh-3.5.0get_all_manifests.shand re-runopendatahub-operator-rhoai-e2eMade with Cursor