Skip to content

sync(workbenches): mirror workbenchNamespace into DSC status - #37087

Merged
carlkyrillos merged 1 commit into
red-hat-data-services:rhoai-3.5from
harshad16:sync-status-workbenchNamespace
Jul 30, 2026
Merged

carlkyrillos merged 1 commit into
red-hat-data-services:rhoai-3.5from
harshad16:sync-status-workbenchNamespace

Conversation

@harshad16

@harshad16 harshad16 commented Jul 30, 2026 •

Copy link
Copy Markdown

Description

Project workbenchNamespace onto status.components.workbenches via an optional workbenches-only writer, so the dashboard can resolve the legacy notebooks namespace without changing the generic release/managementState mirroring from #3838.

Sync PR related-to: opendatahub-io#3890

Created via:

git checkout rhoai-3.5
git checkout -b sync-status-workbenchNamespace
git cherry-pick 573ae314b26378e16b4e56ab94d5fed3df5d8c51
git push

JIRA: https://redhat.atlassian.net/browse/RHOAIENG-79812

How Has This Been Tested?

Defined in: opendatahub-io#3890

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has run the integration test pipeline and verified that it passed successfully
  • New RELATED_IMAGE mappings are listed in ODH-Build-Config and RHOAI-Build-Config (CI validates names against build-config repos). Include links to build-config PRs in the description.

E2E test suite update requirement

When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.

To opt-out of this requirement:

  1. Please inspect the opt-out guidelines, to determine if the nature of the PR changes allows for skipping this requirement
  2. If opt-out is applicable, provide justification in the dedicated E2E update requirement opt-out justification section below
  3. Check the checkbox below:
  • Skip requirement to update E2E test suite for this PR
  1. Submit/save these changes to the PR description. This will automatically trigger the check.

E2E update requirement opt-out justification

…ahub-io#3890)

Project workbenchNamespace onto status.components.workbenches via
an optional workbenches-only writer, so the dashboard can resolve
the legacy notebooks namespace without changing the generic
release/managementState mirroring from opendatahub-io#3838.

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.78%. Comparing base (f3a5510) to head (8fe24ba).
⚠️ Report is 70 commits behind head on rhoai-3.5.

Files with missing lines Patch % Lines
...l/controller/modules/modules_controller_actions.go 33.33% 6 Missing and 2 partials ⚠️
internal/controller/modules/workbenches/handler.go 77.77% 2 Missing and 2 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##           rhoai-3.5   #37087      +/-   ##
=============================================
- Coverage      60.01%   59.78%   -0.23%     
=============================================
  Files            219      217       -2     
  Lines          17408    17175     -233     
=============================================
- Hits           10447    10268     -179     
+ Misses          6021     5980      -41     
+ Partials         940      927      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlkyrillos
carlkyrillos merged commit e623380 into red-hat-data-services:rhoai-3.5 Jul 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants